better LiblineaR specific penalty error

Author: EmilHvitfeldt

R/logistic_reg.R

@@ -154,9 +154,10 @@ check_args.logistic_reg <- function(object, call = rlang::caller_env()) {
       )
     }
 
-    if (all(is.numeric(args$penalty)) && !all(args$penalty > 0)) {
+    if ((!is.null(args$penalty)) && args$penalty <= 0) {
       cli::cli_abort(
-        "For the {.pkg LiblineaR} engine, {.arg penalty} must be {.code > 0}.",
+        "For the {.pkg LiblineaR} engine, {.arg penalty} must be {.code > 0}, \\
+        not {args$penalty}.",
         call = call
       )
     }

tests/testthat/_snaps/logistic_reg.md

@@ -69,5 +69,5 @@
       fit(spec, Class ~ ., lending_club)
     Condition
       Error in `fit()`:
-      ! For the LiblineaR engine, `penalty` must be `> 0`.
+      ! For the LiblineaR engine, `penalty` must be `> 0`, not 0.