Skip to content

Commit bed8ca9

Browse files
authored
Merge pull request #343 from tidymodels/fix-spark-tests
Fix Spark tests
2 parents d0cced3 + c9df05f commit bed8ca9

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

tests/testthat/test_boost_tree_spark.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ test_that('spark execution', {
3030
boost_tree(trees = 5, mode = "regression") %>%
3131
set_engine("spark", seed = 12),
3232
control = ctrl,
33-
class ~ .,
33+
compounds ~ .,
3434
data = hpc_bt_tr
3535
),
3636
regexp = NA

tests/testthat/test_descriptors.R

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -198,29 +198,30 @@ test_that("spark descriptor", {
198198
npk_descr <- copy_to(sc, npk[, 1:4], "npk_descr", overwrite = TRUE)
199199
hpc_descr <- copy_to(sc, hpc, "hpc_descr", overwrite = TRUE)
200200

201-
# spark does not allow .x, .y, .dat
201+
# spark does not allow .x, .y, .dat; spark handles factors differently
202202
template2 <- purrr::partial(template, x = NULL, y = NULL, dat = NULL)
203203
eval_descrs2 <- purrr::partial(eval_descrs, not = c(".x", ".y", ".dat"))
204+
class_tab2 <- table(as.character(hpc$class), dnn = NULL)
204205

205206
expect_equal(
206-
template2(5, 4, 150, NA, 1),
207-
eval_descrs2(get_descr_form(Sepal_Width ~ ., data = hpc_descr))
207+
template2(6, 4, 150, NA, 1),
208+
eval_descrs2(get_descr_form(compounds ~ ., data = hpc_descr))
208209
)
209210
expect_equal(
210-
template2(2, 1, 150, NA, 1),
211-
eval_descrs2(get_descr_form(Sepal_Width ~ class, data = hpc_descr))
211+
template2(3, 1, 150, NA, 1),
212+
eval_descrs2(get_descr_form(compounds ~ class, data = hpc_descr))
212213
)
213214
expect_equal(
214215
template2(1, 1, 150, NA, 0),
215-
eval_descrs2(get_descr_form(Sepal_Width ~ Sepal_Length, data = hpc_descr))
216+
eval_descrs2(get_descr_form(compounds ~ input_fields, data = hpc_descr))
216217
)
217218
expect_equivalent(
218-
template2(4, 4, 150, class_tab, 0),
219+
template2(4, 4, 150, class_tab2, 0),
219220
eval_descrs2(get_descr_form(class ~ ., data = hpc_descr))
220221
)
221222
expect_equal(
222-
template2(1, 1, 150, class_tab, 0),
223-
eval_descrs2(get_descr_form(class ~ Sepal_Length, data = hpc_descr))
223+
template2(1, 1, 150, class_tab2, 0),
224+
eval_descrs2(get_descr_form(class ~ input_fields, data = hpc_descr))
224225
)
225226
expect_equivalent(
226227
template2(7, 3, 24, rev(table(npk$K, dnn = NULL)), 3),

tests/testthat/test_linear_reg_spark.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test_that('spark execution', {
2828
fit(
2929
linear_reg() %>% set_engine("spark"),
3030
control = ctrl,
31-
Sepal_Length ~ .,
31+
compounds ~ .,
3232
data = hpc_linreg_tr
3333
),
3434
regexp = NA

tests/testthat/test_multinom_reg_spark.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ test_that('spark execution', {
6666

6767
expect_equal(
6868
colnames(spark_class_prob),
69-
c("pred_versicolor", "pred_virginica", "pred_setosa")
69+
c("pred_VF", "pred_F", "pred_L", "pred_M")
7070
)
7171

7272
expect_equivalent(

tests/testthat/test_rand_forest_spark.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ test_that('spark execution', {
3131
rand_forest(trees = 5, mode = "regression") %>%
3232
set_engine("spark", seed = 12),
3333
control = ctrl,
34-
Sepal_Length ~ .,
34+
compounds ~ .,
3535
data = hpc_rf_tr
3636
),
3737
regexp = NA
@@ -44,7 +44,7 @@ test_that('spark execution', {
4444
rand_forest(trees = 5, mode = "regression") %>%
4545
set_engine("spark", seed = 12),
4646
control = ctrl,
47-
Sepal_Length ~ .,
47+
compounds ~ .,
4848
data = hpc_rf_tr
4949
),
5050
regexp = NA

0 commit comments

Comments
 (0)