convert warning to error

Author: topepo

R/sparsevctrs.R

@@ -3,12 +3,10 @@ to_sparse_data_frame <- function(x, object) {
     if (allow_sparse(object)) {
       x <- sparsevctrs::coerce_to_sparse_data_frame(x)
     } else {
-      cli::cli_warn(c(
-        "!" = "{.arg x} is a sparse matrix, but model doesn't accept that.",
-        "i" = "Converted {.arg x} to data.frame."
-      ))
-      x <- as.data.frame(as.matrix(x))
+      cli::cli_abort(
+      "{.arg x} is a sparse matrix, but {.fn {class(object)[1]}} with
+       engine {.code {object$engine}} doesn't accept that.")
     }
   }
   x
-}
+}

tests/testthat/_snaps/sparsevctrs.md

@@ -3,9 +3,8 @@
     Code
       lm_fit <- fit_xy(spec, x = hotel_data[1:100, -1], y = hotel_data[1:100, 1])
     Condition
-      Warning:
-      ! `x` is a sparse matrix, but model doesn't accept that.
-      i Converted `x` to data.frame.
+      Error in `to_sparse_data_frame()`:
+      ! `x` is a sparse matrix, but `linear_reg()` with engine `lm` doesn't accept that.
 
 # to_sparse_data_frame() is used correctly
 

tests/testthat/test-sparsevctrs.R

@@ -16,13 +16,14 @@ test_that("sparse matrices can be passed to `fit_xy()", {
     set_engine("lm")
 
   expect_snapshot(
-    lm_fit <- fit_xy(spec, x = hotel_data[1:100, -1], y = hotel_data[1:100, 1])
+    lm_fit <- fit_xy(spec, x = hotel_data[1:100, -1], y = hotel_data[1:100, 1]),
+    error = TRUE
   )
 })
 
 test_that("to_sparse_data_frame() is used correctly", {
   skip_if_not_installed("LiblineaR")
-  
+
   local_mocked_bindings(
     to_sparse_data_frame = function(x, object) {
       if (methods::is(x, "sparseMatrix")) {
@@ -49,7 +50,7 @@ test_that("to_sparse_data_frame() is used correctly", {
     error = TRUE,
     fit_xy(spec, x = hotel_data[, -1], y = hotel_data[, 1])
   )
-  
+
   spec <- svm_linear() %>%
     set_mode("regression") %>%
     set_engine("LiblineaR")
@@ -62,7 +63,7 @@ test_that("to_sparse_data_frame() is used correctly", {
 
 test_that("maybe_sparse_matrix() is used correctly", {
   skip_if_not_installed("LiblineaR")
-  
+
   local_mocked_bindings(
     maybe_sparse_matrix = function(x) {
       if (any(vapply(x, sparsevctrs::is_sparse_vector, logical(1)))) {