Skip to content

Better mtry check for formulas #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Better mtry check for formulas #700

merged 4 commits into from
Apr 11, 2022

Conversation

topepo
Copy link
Member

@topepo topepo commented Apr 11, 2022

With survival random forest models (which usually take the formula), the code that check to see what the upper limit for mtry needed to be updated.

This function looks at the res of the formula, does a call to model.frame() with a small number of data points and gets the predictor data frame. From this, we can determine how large mtry can be.

This update also:

  • Moves the mtry check for partykit models to cforest_train().
  • Adjusts the random forest translate() function to not use min_cols() with partykit models

@topepo topepo requested a review from hfrick April 11, 2022 00:28
@topepo topepo merged commit 5e79150 into main Apr 11, 2022
@topepo topepo deleted the mtry-check branch April 11, 2022 13:56
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants