eval time filtering now in parsnip

topepo · topepo · commit 8082b4143c54 · 2023-03-15T16:26:10.000-04:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -27,7 +27,7 @@ Imports:
     GPfit,
     hardhat (>= 1.2.0),
     lifecycle (>= 1.0.0),
-    parsnip (>= 1.0.2),
+    parsnip (>= 1.0.4.9004),
     purrr (>= 1.0.0),
     recipes (>= 1.0.4),
     rlang (>= 1.0.6.9000),
diff --git a/R/checks.R b/R/checks.R
@@ -628,14 +628,6 @@ check_eval_time <- function(eval_time, metrics) {
       call = NULL
     )
   }
+  invisible(NULL)
 
-  # will still propagate nulls
-  eval_time <- eval_time[!is.na(eval_time)]
-  eval_time <- unique(eval_time)
-  eval_time <- sort(eval_time)
-  eval_time <- eval_time[eval_time >= 0 & is.finite(eval_time)]
-  if (identical(eval_time, numeric(0))) {
-    rlang::abort("There were no usable evaluation times (finite, non-missing, and >= 0).", call = NULL)
-  }
-  eval_time
 }
diff --git a/R/tune_grid.R b/R/tune_grid.R
@@ -328,7 +328,7 @@ tune_grid_workflow <- function(workflow,
 
 
   metrics <- check_metrics(metrics, workflow)
-  eval_time <- check_eval_time(eval_time, metrics)
+  check_eval_time(eval_time, metrics)
 
   pset <- check_parameters(
     workflow,

Original file line number	Diff line number	Diff line change
`@@ -628,14 +628,6 @@ check_eval_time <- function(eval_time, metrics) {`
`628`	`628`	`call = NULL`
`629`	`629`	`)`
`630`	`630`	`}`
	`631`	`+ invisible(NULL)`
`631`	`632`
`632`		`- # will still propagate nulls`
`633`		`- eval_time <- eval_time[!is.na(eval_time)]`
`634`		`- eval_time <- unique(eval_time)`
`635`		`- eval_time <- sort(eval_time)`
`636`		`- eval_time <- eval_time[eval_time >= 0 & is.finite(eval_time)]`
`637`		`- if (identical(eval_time, numeric(0))) {`
`638`		`- rlang::abort("There were no usable evaluation times (finite, non-missing, and >= 0).", call = NULL)`
`639`		`- }`
`640`		`- eval_time`
`641`	`633`	`}`