Skip to content

Commit 3be5d6c

Browse files
authored
No ticks no space (#6071)
* no space for blank ticks * preserve axis text spacing for `theme_minimal()` * add news bullet
1 parent f52de1c commit 3be5d6c

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,8 @@
219219
* New theme elements `palette.{aes}.discrete` and `palette.{aes}.continuous`.
220220
Theme palettes replace palettes in scales where `palette = NULL`, which is
221221
the new default in many scales (@teunbrand, #4696).
222+
* `guide_axis()` no longer reserves space for blank ticks
223+
(@teunbrand, #4722, #6069).
222224

223225
# ggplot2 3.5.1
224226

R/guide-axis.R

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,12 @@ GuideAxis <- ggproto(
256256
override_elements = function(params, elements, theme) {
257257
elements$text <-
258258
label_angle_heuristic(elements$text, params$position, params$angle)
259+
if (inherits(elements$ticks, "element_blank")) {
260+
elements$major_length <- unit(0, "cm")
261+
}
262+
if (inherits(elements$minor, "element_blank") || isFALSE(params$minor.ticks)) {
263+
elements$minor_length <- unit(0, "cm")
264+
}
259265
return(elements)
260266
},
261267

R/theme-defaults.R

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,11 @@ theme_minimal <- function(base_size = 11, base_family = "",
451451
ink = ink, paper = paper
452452
) %+replace%
453453
theme(
454-
axis.ticks = element_blank(),
454+
axis.ticks = element_blank(), # Extra margins due to absence ticks
455+
axis.text.x.bottom = element_text(margin = margin(t = 0.45 * base_size)),
456+
axis.text.x.top = element_text(margin = margin(b = 0.45 * base_size)),
457+
axis.text.y.left = element_text(margin = margin(r = 0.45 * base_size)),
458+
axis.text.y.right = element_text(margin = margin(l = 0.45 * base_size)),
455459
legend.background = element_blank(),
456460
legend.key = element_blank(),
457461
panel.background = element_blank(),

0 commit comments

Comments
 (0)