descriptive error message in ggsave if device cannot be found from file extension

Sebastian Kopf · Sebastian Kopf · commit 6534a6d0dc9f · 2014-04-06T17:21:20.000-07:00
basically if user tries to ggsave a filename with an unknown extension
diff --git a/R/save.r b/R/save.r
@@ -75,7 +75,8 @@ ggsave <- function(filename = default_name(plot), plot = last_plot(),
   }
   
   default_device <- function(ext) {
-    match.fun(ext)
+    tryCatch(match.fun(ext), error = function(e) 
+      stop(sprintf("Cannot find a graphics device that matches file extension '%s'.", ext)))
   }
 
   units <- match.arg(units)

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,8 @@ ggsave <- function(filename = default_name(plot), plot = last_plot(),`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`default_device <- function(ext) {`
`78`		`- match.fun(ext)`
	`78`	`+ tryCatch(match.fun(ext), error = function(e)`
	`79`	`+ stop(sprintf("Cannot find a graphics device that matches file extension '%s'.", ext)))`
`79`	`80`	`}`
`80`	`81`
`81`	`82`	`units <- match.arg(units)`