Axis text outside panel with inward ticks (#4392)

Author: teunbrand

R/guides-axis.r

@@ -280,7 +280,7 @@ draw_axis <- function(break_positions, break_labels, axis_position, theme,
   non_position_sizes <- paste0(non_position_size, "s")
   label_dims <- do.call(unit.c, lapply(label_grobs, measure_labels_non_pos))
   grobs <- c(list(ticks_grob), label_grobs)
-  grob_dims <- unit.c(tick_length, label_dims)
+  grob_dims <- unit.c(max(tick_length, unit(0, "pt")), label_dims)
 
   if (labels_first_gtable) {
     grobs <- rev(grobs)

tests/testthat/test-theme.r

@@ -562,8 +562,8 @@ test_that("axes ticks can have independent lengths", {
       axis.ticks.length.x.bottom = unit(-.25, "cm"),
       axis.ticks.length.y.left = unit(.25, "cm"),
       axis.ticks.length.y.right = unit(.5, "cm"),
-      axis.text.x.bottom = element_text(margin = margin(t = .5, unit = "cm")),
-      axis.text.x.top = element_text(margin = margin(b = .75, unit = "cm"))
+      axis.text.x.bottom = element_text(margin = margin(t = .25, unit = "cm")),
+      axis.text.x.top = element_text(margin = margin(b = .25, unit = "cm"))
     )
   expect_doppelganger("ticks_length", plot)
 })