Merge pull request #5171 from tidyverse/v3.4.1-rc

Release ggplot2 3.4.1

Author: thomasp85

DESCRIPTION

@@ -1,13 +1,13 @@
 Package: ggplot2
-Version: 3.4.0.9000
+Version: 3.4.1.9000
 Title: Create Elegant Data Visualisations Using the Grammar of Graphics
 Authors@R: c(
-    person("Hadley", "Wickham", , "hadley@rstudio.com", role = "aut",
+    person("Hadley", "Wickham", , "hadley@posit.co", role = "aut",
            comment = c(ORCID = "0000-0003-4757-117X")),
     person("Winston", "Chang", role = "aut",
            comment = c(ORCID = "0000-0002-1576-2126")),
     person("Lionel", "Henry", role = "aut"),
-    person("Thomas Lin", "Pedersen", , "thomas.pedersen@rstudio.com", role = c("aut", "cre"),
+    person("Thomas Lin", "Pedersen", , "thomas.pedersen@posit.co", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0002-5147-4711")),
     person("Kohske", "Takahashi", role = "aut"),
     person("Claus", "Wilke", role = "aut",

NEWS.md

@@ -6,33 +6,57 @@
   packages (@teunbrand, #4701).
 * `geom_text()` drops observations where `angle = NA` instead of throwing an
   error (@teunbrand, #2757).
+* `update_geom_defaults()` and `update_stat_defaults()` now return properly 
+  classed objects and have updated docs (@dkahle, #5146)
+  
+# ggplot2 3.4.1
+This is a small release focusing on fixing regressions in the 3.4.0 release
+and minor polishes.
+
+## Breaking changes
+
+* The computed variable `y` in `stat_ecdf()` has been superseded by `ecdf` to 
+  prevent incorrect scale transformations (@teunbrand, #5113 and #5112).
+  
+## New features
+
+* Added `scale_linewidth_manual()` and `scale_linewidth_identity()` to support
+  the `linewidth` aesthetic (@teunbrand, #5050).
+  
+* `ggsave()` warns when multiple `filename`s are given, and only writes to the
+  first file (@teunbrand, #5114).
+
+## Bug fixes
+
+* Fixed a regression in `geom_hex()` where aesthetics were replicated across 
+  bins (@thomasp85, #5037 and #5044).
+  
 * Using two ordered factors as facetting variables in 
   `facet_grid(..., as.table = FALSE)` now throws a warning instead of an
   error (@teunbrand, #5109).
-* Added `scale_linewidth_manual()` and `scale_linewidth_identity()` to support
-  the `linewidth` aesthetic (@teunbrand, #5050).
-* Automatic breaks in `scale_*_binned()` should no longer be out-of-bounds,
-  and automatic limits expand to include these (@teunbrand, #5095, #5100).
-* Renamed computed aesthetic in `stat_ecdf()` to `ecdf`, to prevent incorrect
-  scale transformations (@teunbrand, #5113 and #5112).
+  
 * Fixed misbehaviour of `draw_key_boxplot()` and `draw_key_crossbar()` with 
   skewed key aspect ratio (@teunbrand, #5082).
-* `scale_*_binned()` handles zero-range limits more gracefully (@teunbrand, 
-  #5066)
-* Binned scales are now compatible with `trans = "date"` and `trans = "time"` 
-  (@teunbrand, #4217).
-* `ggsave()` warns when multiple `filename`s are given, and only writes to the
-  first file (@teunbrand, #5114)
-* Fixed a regression in `geom_hex()` where aesthetics were replicated across 
-  bins (@thomasp85, #5037 and #5044)
+  
 * Fixed spurious warning when `weight` aesthetic was used in `stat_smooth()` 
   (@teunbrand based on @clauswilke's suggestion, #5053).
-* The `lwd` alias now correctly replaced by `linewidth` instead of `size` 
+  
+* The `lwd` alias is now correctly replaced by `linewidth` instead of `size` 
   (@teunbrand based on @clauswilke's suggestion #5051).
+  
 * Fixed a regression in `Coord$train_panel_guides()` where names of guides were 
-  dropped (@maxsutton, #5063)
-* `update_geom_defaults()` and `update_stat_defaults()` now return properly 
-  classed objects and have updated docs (@dkahle, #5146)
+  dropped (@maxsutton, #5063).
+
+In binned scales:
+
+* Automatic breaks should no longer be out-of-bounds, and automatic limits are
+  adjusted to include breaks (@teunbrand, #5082).
+  
+* Zero-range limits no longer throw an error and are treated akin to continuous
+  scales with zero-range limits (@teunbrand, #5066).
+  
+* The `trans = "date"` and `trans = "time"` transformations were made compatible
+  (@teunbrand, #4217).
 
 # ggplot2 3.4.0
 This is a minor release focusing on tightening up the internals and ironing out

R/stat-ecdf.r

@@ -21,7 +21,8 @@
 #' @param pad If `TRUE`, pad the ecdf with additional points (-Inf, 0)
 #'   and (Inf, 1)
 #' @eval rd_computed_vars(
-#'   ecdf = "Cumulative density corresponding to `x`."
+#'   ecdf = "Cumulative density corresponding to `x`.",
+#'   y    = "`r lifecycle::badge('superseded')` For backward compatibility."
 #' )
 #' @export
 #' @examples
@@ -103,6 +104,7 @@ StatEcdf <- ggproto("StatEcdf", Stat,
 
     df_ecdf <- data_frame0(
       x = x,
+      y = data_ecdf,
       ecdf = data_ecdf,
       .size = length(x)
     )

R/stat-ellipse.R

@@ -6,7 +6,7 @@
 #' @references John Fox and Sanford Weisberg (2011). An \R Companion to
 #'   Applied Regression, Second Edition. Thousand Oaks CA: Sage. URL:
 #'   \url{https://socialsciences.mcmaster.ca/jfox/Books/Companion/}
-#' @refereces Michael Friendly. Georges Monette. John Fox. "Elliptical Insights: Understanding Statistical Methods through Elliptical Geometry." 
+#' @references Michael Friendly. Georges Monette. John Fox. "Elliptical Insights: Understanding Statistical Methods through Elliptical Geometry."
 #' Statist. Sci. 28 (1) 1 - 39, February 2013. URL: \url{https://projecteuclid.org/journals/statistical-science/volume-28/issue-1/Elliptical-Insights-Understanding-Statistical-Methods-through-Elliptical-Geometry/10.1214/12-STS402.full}
 #'
 #' @param level The level at which to draw an ellipse,

cran-comments.md

@@ -1,194 +1,70 @@
-This is a minor release focusing on internal changes.
-
-We have tested reverse dependencies and contacted failing packages 4 weeks ago,
-notifying them of the failure and where in their code they need to look.
-
-At the time of submission 44 packages are still failing.
+This is a patch release fixing a couple of regressions in the last release. We
+see two failing revdeps at the time of submission. Both have been notified 16 
+days ago.
 
 ## revdepcheck results
 
-We checked 4238 reverse dependencies (4224 from CRAN + 14 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
+We checked 4375 reverse dependencies (4350 from CRAN + 25 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
 
- * We saw 46 new problems
- * We failed to check 22 packages
+ * We saw 2 new problems
+ * We failed to check 46 packages
 
 Issues with CRAN packages are summarised below.
 
 ### New problems
 (This reports the first line of each new failure)
 
-* afex
-  checking re-building of vignette outputs ... WARNING
-
-* antaresViz
-  checking tests ... ERROR
-
-* bayesplot
-  checking tests ... ERROR
-
-* bigsnpr
-  checking tests ... ERROR
-
-* chronochrt
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking re-building of vignette outputs ... WARNING
-
-* coveffectsplot
-  checking re-building of vignette outputs ... WARNING
-
-* dataquieR
-  checking tests ... ERROR
-
-* deeptime
-  checking dependencies in R code ... WARNING
-
-* docxtools
-  checking tests ... ERROR
-
-* DriveML
-  checking re-building of vignette outputs ... WARNING
-
-* evaluate
-  checking tests ... ERROR
-
-* fdistr
-  checking tests ... ERROR
-
-* ggbeeswarm
-  checking examples ... ERROR
-
-* ggconf
-  checking examples ... ERROR
-  checking tests ... ERROR
-
-* ggdag
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking dependencies in R code ... WARNING
-  checking re-building of vignette outputs ... WARNING
-
-* ggetho
-  checking dependencies in R code ... WARNING
-
-* ggfun
-  checking dependencies in R code ... WARNING
-
-* gghalves
-  checking examples ... ERROR
-  checking re-building of vignette outputs ... WARNING
-
-* ggip
-  checking tests ... ERROR
-
-* ggiraph
-  checking examples ... ERROR
-  checking tests ... ERROR
-
-* ggiraphExtra
-  checking examples ... ERROR
-  checking re-building of vignette outputs ... WARNING
-
-* gglgbtq
-  checking dependencies in R code ... WARNING
-
-* ggmap
-  checking dependencies in R code ... WARNING
-
-* ggmulti
-  checking examples ... ERROR
-  checking dependencies in R code ... WARNING
-
-* ggpubr
-  checking examples ... ERROR
-
-* ggstance
-  checking dependencies in R code ... WARNING
-
-* ggstar
-  checking dependencies in R code ... WARNING
-
-* iheiddown
-  checking tests ... ERROR
-
-* inTextSummaryTable
-  checking tests ... ERROR
-
-* jjAnno
-  checking examples ... ERROR
-
-* lemon
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking re-building of vignette outputs ... WARNING
-
-* lingtypology
-  checking examples ... ERROR
-
 * listdown
   checking tests ... ERROR
 
-* openalexR
-  checking re-building of vignette outputs ... WARNING
-
-* pathviewr
-  checking tests ... ERROR
-
-* plotly
-  checking tests ... ERROR
-
-* plotmm
-  checking examples ... ERROR
-
-* qqboxplot
-  checking examples ... ERROR
-  checking re-building of vignette outputs ... WARNING
-
-* RJafroc
-  checking tests ... ERROR
-
-* robustlmm
-  checking running R code from vignettes ... WARNING
-
-* scdhlm
-  checking tests ... ERROR
-
-* schtools
-  checking tests ... ERROR
-
-* tcpl
-  checking re-building of vignette outputs ... WARNING
-
-* tvthemes
-  checking tests ... ERROR
-
-* usmap
-  checking tests ... ERROR
-
 * xpose
   checking tests ... ERROR
 
 ### Failed to check
 
-* CausalImpact    (NA)
-* ctsem           (NA)
-* expss           (NA)
-* ggPMX           (NA)
-* ggprism         (NA)
-* ggshadow        (NA)
-* ggtern          (NA)
-* loon.ggplot     (NA)
-* nlmixr2         (NA)
-* nlmixr2extra    (NA)
-* nlmixr2plot     (NA)
-* OpenMx          (NA)
-* Platypus        (NA)
-* RcppCensSpatial (NA)
-* rPBK            (NA)
-* simpr           (NA)
-* Sofi            (NA)
-* SSVS            (NA)
-* tidySEM         (NA)
-* valse           (NA)
-* vivid           (NA)
-* xpose.nlmixr2   (NA)
+* AFM                     (NA)
+* AssetCorr               (NA)
+* bayesnec                (NA)
+* bayesrules              (NA)
+* cinaR                   (NA)
+* eefAnalytics            (NA)
+* escalation              (NA)
+* ESTER                   (NA)
+* genekitr                (NA)
+* ggPMX                   (NA)
+* grandR                  (NA)
+* hmmTMB                  (NA)
+* immcp                   (NA)
+* INSPECTumours           (NA)
+* IRexamples              (NA)
+* loon.ggplot             (NA)
+* MarketMatching          (NA)
+* MARVEL                  (NA)
+* multilevelcoda          (NA)
+* nestedcv                (NA)
+* nlmixr2                 (NA)
+* nlmixr2extra            (NA)
+* nlmixr2plot             (NA)
+* nlmixr2rpt              (NA)
+* numbat                  (NA)
+* OlinkAnalyze            (NA)
+* OpenMx                  (NA)
+* ordbetareg              (NA)
+* PFIM                    (NA)
+* PlasmaMutationDetector2 (NA)
+* Platypus                (NA)
+* RcppCensSpatial         (NA)
+* rdddr                   (NA)
+* rdss                    (NA)
+* rstan                   (NA)
+* RVA                     (NA)
+* SCpubr                  (NA)
+* tidyposterior           (NA)
+* tidySEM                 (NA)
+* tinyarray               (NA)
+* TVMM                    (NA)
+* valse                   (NA)
+* vivid                   (NA)
+* wearables               (NA)
+* webSDM                  (NA)
+* xpose.nlmixr2           (NA)

inst/CITATION

@@ -1,11 +1,11 @@
-citHeader("To cite ggplot2 in publications, please use:")
-
-citEntry(entry = "book",
+bibentry(
+  bibtype = "Book",
+  textVersion = "H. Wickham. ggplot2: Elegant Graphics for Data Analysis. Springer-Verlag New York, 2016.",
+  header = "To cite ggplot2 in publications, please use",
   author = "Hadley Wickham",
   title = "ggplot2: Elegant Graphics for Data Analysis",
   publisher = "Springer-Verlag New York",
   year = "2016",
   isbn = "978-3-319-24277-4",
   url = "https://ggplot2.tidyverse.org",
-  textVersion = "H. Wickham. ggplot2: Elegant Graphics for Data Analysis. Springer-Verlag New York, 2016."
 )