Add translate_string_shape to GeomSf (#6039)

sierrajohnson · web-flow · commit ee5c9e5b4f0e · 2024-08-15T15:16:07.000-07:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # ggplot2 (development version)
 
+* geom_sf now accepts shape names (@sierrajohnson, #5808)
 * Added `gg` class to `labs()` (@phispu, #5553).
 * Missing values from discrete palettes are no longer translated 
   (@teunbrand, #5929).
diff --git a/R/geom-sf.R b/R/geom-sf.R
@@ -200,6 +200,9 @@ GeomSf <- ggproto("GeomSf", Geom,
     if (!inherits(coord, "CoordSf")) {
       cli::cli_abort("{.fn {snake_class(self)}} can only be used with {.fn coord_sf}.")
     }
+    if (is.character(data$shape)) {
+      data$shape <- translate_shape_string(data$shape)
+    }
 
     data <- coord$transform(data, panel_params)
 

Original file line number	Diff line number	Diff line change
`@@ -200,6 +200,9 @@ GeomSf <- ggproto("GeomSf", Geom,`
`200`	`200`	`if (!inherits(coord, "CoordSf")) {`
`201`	`201`	`cli::cli_abort("{.fn {snake_class(self)}} can only be used with {.fn coord_sf}.")`
`202`	`202`	`}`
	`203`	`+ if (is.character(data$shape)) {`
	`204`	`+ data$shape <- translate_shape_string(data$shape)`
	`205`	`+ }`
`203`	`206`
`204`	`207`	`data <- coord$transform(data, panel_params)`
`205`	`208`