Skip to content

Commit 004efa6

Browse files
authored
build(ci): Properly skip node CI steps when not changed (getsentry#10487)
One part of getsentry#10486, actually our checks for this were not correct 😅 This is still only a partial fix as if we change anything in core etc. we'll still have the build overhead every time, but it's something!
1 parent 84baeb1 commit 004efa6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,7 @@ jobs:
510510

511511
job_node_unit_tests:
512512
name: Node (${{ matrix.node }}) Unit Tests
513+
if: needs.job_get_metadata.outputs.changed_node == 'true' || github.event_name != 'pull_request'
513514
needs: [job_get_metadata, job_build]
514515
timeout-minutes: 10
515516
runs-on: ubuntu-20.04
@@ -542,7 +543,7 @@ jobs:
542543
job_profiling_node_unit_tests:
543544
name: Node Profiling Unit Tests
544545
needs: [job_get_metadata, job_build]
545-
if: needs.job_get_metadata.outputs.changed_node || needs.job_get_metadata.outputs.changed_profiling_node == 'true' || github.event_name != 'pull_request'
546+
if: needs.job_get_metadata.outputs.changed_node =='true' || needs.job_get_metadata.outputs.changed_profiling_node == 'true' || github.event_name != 'pull_request'
546547
runs-on: ubuntu-latest
547548
timeout-minutes: 10
548549
steps:
@@ -1217,7 +1218,7 @@ jobs:
12171218
# if profiling or profiling node package had changed or if we are on a release branch.
12181219
if: |
12191220
(needs.job_get_metadata.outputs.changed_profiling_node == 'true') ||
1220-
(needs.job_get_metadata.outputs.is_release) ||
1221+
(needs.job_get_metadata.outputs.is_release == 'true') ||
12211222
(github.event_name != 'pull_request')
12221223
runs-on: ${{ matrix.os }}
12231224
container: ${{ matrix.container }}

0 commit comments

Comments
 (0)