no zero

Author: timfish

packages/node/src/stack-parser.ts

@@ -112,18 +112,12 @@ export const node: StackLineParser = (line: string) => {
   // see https://github.com/getsentry/raven-node/issues/176
   const in_app = !isInternal && filename !== undefined && !filename.includes('node_modules/');
 
-  /** Gets int from string or undefined if NaN */
-  function getInt(int: string): number | undefined {
-    const val = parseInt(int, 10);
-    return isNaN(val) ? undefined : val;
-  }
-
   return {
     filename: lineMatch[2],
     module: getModule(filename),
     function: fn,
-    lineno: getInt(lineMatch[3]),
-    colno: getInt(lineMatch[4]),
+    lineno: parseInt(lineMatch[3], 10) || undefined,
+    colno: parseInt(lineMatch[4], 10) || undefined,
     in_app,
   };
 };

packages/node/test/stacktrace.test.ts

@@ -40,24 +40,6 @@ describe('Stack parsing', () => {
     expect(frames[last - 2].function).toEqual('eval');
   });
 
-  test('parses with zero row/col', () => {
-    const err: { [key: string]: any } = {};
-    err.stack = 'Error: Foo\n' + '    at Timer.listOnTimeout [as ontimeout] (timers.js:0:0)\n';
-
-    const frames = extractStackFromError(err as Error);
-
-    expect(frames).toEqual([
-      {
-        filename: 'timers.js',
-        module: 'timers',
-        function: 'Timer.listOnTimeout [as ontimeout]',
-        lineno: 0,
-        colno: 0,
-        in_app: false,
-      },
-    ]);
-  });
-
   test('parses object in fn name', () => {
     const err: { [key: string]: any } = {};
     err.stack =