Skip to content

Commit 6cb052a

Browse files
committed
minor improvements
1 parent ee502cd commit 6cb052a

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

src/tldr.c

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,18 @@
3030
#endif
3131

3232
#if defined(_WIN32)
33-
33+
/* nothing yet */
3434
#elif __APPLE__
3535
#include "TargetConditionals.h"
3636
#if TARGET_OS_MAC
37-
37+
/* nothing yet */
3838
#endif
3939
#elif __linux__
40-
40+
/* nothing yet */
4141
#elif __unix__
42-
42+
/* nothing yet */
4343
#elif defined(_POSIX_VERSION)
44-
44+
/* nothing yet */
4545
#else
4646
#error "Unknown Compiler"
4747
#endif
@@ -425,6 +425,8 @@ print_tldrpage(char const* input, char const* poverride)
425425
if (homedir == NULL) { return 1; }
426426

427427
homelen = strlen(homedir);
428+
if ((homelen + TLDR_EXT_LEN + 1) > 1024) { return 1; }
429+
428430
memcpy(directory, homedir, homelen);
429431
memcpy(directory + homelen, TLDR_EXT, TLDR_EXT_LEN);
430432
directory[homelen + TLDR_EXT_LEN] = '\0';
@@ -511,6 +513,8 @@ check_localdate(void)
511513
if (homedir == NULL) { return 1; }
512514

513515
homelen = strlen(homedir);
516+
if ((homelen + TLDR_DATE_LEN + 1) > 1024) { return 1; }
517+
514518
memcpy(outdir, homedir, homelen);
515519
memcpy(outdir + homelen, TLDR_DATE, TLDR_DATE_LEN);
516520
outdir[homelen + TLDR_DATE_LEN] = '\0';
@@ -686,6 +690,9 @@ clear_localdb(int verbose)
686690
if (homedir == NULL) { return 1; }
687691

688692
homedirlen = strlen(homedir);
693+
if ((homedirlen + TLDR_HOME_LEN + 1) > 255)
694+
{ return 1; }
695+
689696
memcpy(tmp, homedir, homedirlen);
690697
memcpy(tmp + homedirlen, TLDR_HOME, TLDR_HOME_LEN);
691698
tmp[homedirlen + TLDR_HOME_LEN] = '\0';

0 commit comments

Comments
 (0)