Skip to content

Commit 13ef7f2

Browse files
committed
👌 wrap block to check if elem exist before checking for elem.offsetHeight
1 parent f896446 commit 13ef7f2

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

‎app/components/ember-anchor.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ export default AnchorComponent.extend({
99
let qp = this.anchorQueryParam;
1010
let qpVal = this.get(get(this, 'attrs.a') ? 'a' : `controller.${qp}`);
1111
let elem = document.querySelector(`[data-${qp}="${qpVal}"]`);
12-
const offsetTop = elem.offsetHeight;
1312

14-
if (offsetTop) {
13+
if (elem && elem.offsetHeight) {
1514
const offsetToScroll = getOffset(elem, config.APP.scrollContainerSelector)
1615
document.querySelector(config.APP.scrollContainerSelector).scrollTo(0, offsetToScroll);
1716
}

‎app/mixins/scroll-tracker.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ export default Mixin.create({
1616
this._super();
1717
if ((typeof FastBoot === 'undefined') && window.location.search === '?anchor=' ) {
1818
let elem = document.querySelector('#methods');
19-
let offsetTop = elem.offsetHeight;
2019

21-
if (offsetTop) {
20+
if (elem && elem.offsetHeight) {
2221
const offsetToScroll = getOffset(elem, config.APP.scrollContainerSelector)
2322
document.querySelector(config.APP.scrollContainerSelector).scrollTo(0, offsetToScroll - 10);
2423
return;

0 commit comments

Comments
 (0)