when verbosity level increases above two start passing through verbosity flags to pip #982 (#988)

Author: gaborbernat

changelog/982.feature.rst

@@ -0,0 +1 @@
+when verbosity level increases above two start passing through verbosity flags to pip - by :user:`gaborbernat`

src/tox/_pytestplugin.py

@@ -14,7 +14,7 @@
 from tox import venv
 from tox.config import parseconfig
 from tox.result import ResultLog
-from tox.session import Session, main
+from tox.session import Reporter, Session, main
 from tox.venv import CreationConfig, VirtualEnv, getdigest
 
 mark_dont_run_on_windows = pytest.mark.skipif(os.name == "nt", reason="non windows test")
@@ -128,6 +128,7 @@ def __init__(self, session):
         self._calls = []
         self._index = -1
         self.session = session
+        self.orig_reporter = Reporter(session)
 
     def clear(self):
         self._calls[:] = []
@@ -136,8 +137,7 @@ def __getattr__(self, name):
         if name[0] == "_":
             raise AttributeError(name)
         elif name == "verbosity":
-            # FIXME: special case for property on Reporter class, may it be generalized?
-            return 0
+            return self.orig_reporter.verbosity
 
         def generic_report(*args, **_):
             self._calls.append((name,) + args)

src/tox/config.py

@@ -361,8 +361,9 @@ def tox_addoption(parser):
         action="count",
         dest="verbose_level",
         default=0,
-        help="increase verbosity of reporting output. -vv mode turns off "
-        "output redirection for package installation",
+        help="increase verbosity of reporting output."
+        "-vv mode turns off output redirection for package installation, "
+        "above level two verbosity flags are passed through to pip (with two less level)",
     )
     parser.add_argument(
         "-q",

src/tox/venv.py

@@ -274,7 +274,7 @@ def install_pkg(self, dir, action, name, is_develop=False):
                 return
             action.setactivity("{}-nodeps".format(name), dir)
             pip_flags = ["--no-deps"] + ([] if is_develop else ["-U"])
-
+        pip_flags.extend(["-v"] * min(3, action.report.verbosity - 2))
         if action.venv.envconfig.extras:
             dir += "[{}]".format(",".join(action.venv.envconfig.extras))
         target = [dir]

tests/unit/test_venv.py

@@ -724,6 +724,20 @@ def test_installpkg_no_upgrade(tmpdir, newmocksession):
     assert pcalls[0].args[1:-1] == ["-m", "pip", "install", "--exists-action", "w"]
 
 
+@pytest.mark.parametrize("count, level", [(0, 0), (1, 0), (2, 0), (3, 1), (4, 2), (5, 3), (6, 3)])
+def test_install_command_verbosity(tmpdir, newmocksession, count, level):
+    pkg = tmpdir.ensure("package.tar.gz")
+    mock_session = newmocksession(["-{}".format("v" * count)], "")
+    env = mock_session.getenv("python")
+    env.just_created = True
+    env.envconfig.envdir.ensure(dir=1)
+    mock_session.installpkg(env, pkg)
+    pcalls = mock_session._pcalls
+    assert len(pcalls) == 1
+    expected = ["-m", "pip", "install", "--exists-action", "w"] + (["-v"] * level)
+    assert pcalls[0].args[1:-1] == expected
+
+
 def test_installpkg_upgrade(newmocksession, tmpdir):
     pkg = tmpdir.ensure("package.tar.gz")
     mocksession = newmocksession([], "")