[MLIR][mlir-link] Properly resolve LLVM dialect bitwidth for linkage (#39)

Author: Jezurko

mlir/lib/Dialect/LLVMIR/IR/LLVMLinkerInterface.cpp

@@ -70,8 +70,11 @@ bool  mlir::LLVM::LLVMSymbolLinkerInterface::isDeclaration(Operation *op) {
 }
 
 unsigned  mlir::LLVM::LLVMSymbolLinkerInterface::getBitWidth(Operation *op) {
-  if (auto gv = dyn_cast<LLVM::GlobalOp>(op))
-    return gv.getType().getIntOrFloatBitWidth();
+  if (auto gv = dyn_cast<LLVM::GlobalOp>(op)) {
+    auto type = gv.getType();
+    auto dataLayout = DataLayout::closest(op);
+    return dataLayout.getTypeSizeInBits(type);
+  }
   llvm_unreachable("unexpected operation");
 }
 

mlir/test/mlir-link/common-linkage-c.mlir

@@ -0,0 +1,9 @@
+// RUN: mlir-link -sort-symbols -split-input-file %s | FileCheck %s
+
+// CHECK: llvm.mlir.global common @common_arr{{.*}}!llvm.array<18 x i32>
+
+llvm.mlir.global common @common_arr(dense<0> : tensor<17xi32>) {addr_space = 0 : i32, alignment = 16 : i64, dso_local} : !llvm.array<17 x i32>
+
+// -----
+
+llvm.mlir.global common local_unnamed_addr @common_arr(dense<0> : tensor<18xi32>) {addr_space = 0 : i32, alignment = 16 : i64, dso_local} : !llvm.array<18 x i32>