sigh

Author: 2over12

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

@@ -1093,11 +1093,9 @@ def LLVM_TBAATagArrayAttr
 //===----------------------------------------------------------------------===//
 // ConstantRangeAttr
 //===----------------------------------------------------------------------===//
+
 def LLVM_ConstantRangeAttr : LLVM_Attr<"ConstantRange", "constant_range"> {
-  let parameters = (ins
-    "::llvm::APInt":$lower,
-    "::llvm::APInt":$upper
-  );
+  let parameters = (ins "::llvm::APInt":$lower, "::llvm::APInt":$upper);
   let summary = "A range of two integers, corresponding to LLVM's ConstantRange";
   let description = [{
     A pair of two integers, mapping to the ConstantRange structure in LLVM IR,
@@ -1122,6 +1120,7 @@ def LLVM_ConstantRangeAttr : LLVM_Attr<"ConstantRange", "constant_range"> {
 
   let hasCustomAssemblyFormat = 1;
   let genVerifyDecl = 1;
+  let genStorageClass = 0;
 }
 
 

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrs.h

@@ -23,6 +23,54 @@
 namespace mlir {
 namespace LLVM {
 
+namespace detail {
+struct ConstantRangeAttrStorage : public AttributeStorage {
+  ConstantRangeAttrStorage(llvm::APInt lower, llvm::APInt upper)
+      : lower(lower), upper(upper) {}
+
+  /// The hash key for this storage is a pair of the integer and type params.
+  using KeyTy = std::pair<llvm::APInt, llvm::APInt>;
+
+  /// Define the comparison function for the key type.
+  bool operator==(const KeyTy &key) const {
+    if (lower.getBitWidth() != key.first.getBitWidth() ||
+        upper.getBitWidth() != key.second.getBitWidth()) {
+      return false;
+    }
+    return lower == key.first && upper == key.second;
+  }
+
+  /// Define a hash function for the key type.
+  /// Note: This isn't necessary because std::pair, unsigned, and Type all have
+  /// hash functions already available.
+  static llvm::hash_code hashKey(const KeyTy &key) {
+    return llvm::hash_combine(key.first, key.second);
+  }
+
+  /// Define a construction function for the key type.
+  /// Note: This isn't necessary because KeyTy can be directly constructed with
+  /// the given parameters.
+  static KeyTy getKey(llvm::APInt lower, llvm::APInt upper) {
+    return KeyTy(lower, upper);
+  }
+
+  /// Define a construction method for creating a new instance of this storage.
+  static ConstantRangeAttrStorage *construct(mlir::StorageUniquer::StorageAllocator &allocator, const KeyTy &key) {
+    return new (allocator.allocate<ConstantRangeAttrStorage>())
+        ConstantRangeAttrStorage(key.first, key.second);
+  }
+
+  /// Construct an instance of the key from this storage class.
+  KeyTy getAsKey() const {
+    return KeyTy(lower, upper);
+  }
+
+  /// The parametric data held by the storage class.
+  llvm::APInt lower;
+  llvm::APInt upper;
+};
+}
+
 /// This class represents the base attribute for all debug info attributes.
 class DINodeAttr : public Attribute {
 public:
@@ -96,6 +144,9 @@ using linkage::Linkage;
 
 #include "mlir/Dialect/LLVMIR/LLVMAttrInterfaces.h.inc"
 
+
+
+
 #define GET_ATTRDEF_CLASSES
 #include "mlir/Dialect/LLVMIR/LLVMOpsAttrDefs.h.inc"