Skip to content

Commit 09101fc

Browse files
committed
Fix priority tests by dequeuing in sequence
1 parent f579afb commit 09101fc

File tree

1 file changed

+21
-11
lines changed

1 file changed

+21
-11
lines changed

internal-packages/run-engine/src/engine/tests/priority.test.ts

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { PrismaClientOrTransaction } from "@trigger.dev/database";
66
import { MinimalAuthenticatedEnvironment } from "../../shared/index.js";
77
import { setTimeout } from "timers/promises";
88
import { setupAuthenticatedEnvironment, setupBackgroundWorker } from "./setup.js";
9+
import { DequeuedMessage } from "@trigger.dev/core/v3";
910

1011
vi.setConfig({ testTimeout: 60_000 });
1112

@@ -76,12 +77,16 @@ describe("RunEngine priority", () => {
7677
const queueLength = await engine.runQueue.lengthOfEnvQueue(authenticatedEnvironment);
7778
expect(queueLength).toBe(priorities.length);
7879

79-
//dequeue (expect 4 items because of the negative priority)
80-
const dequeue = await engine.dequeueFromMasterQueue({
81-
consumerId: "test_12345",
82-
masterQueue: "main",
83-
maxRunCount: 20,
84-
});
80+
//dequeue 4 times, in order
81+
const dequeue: DequeuedMessage[] = [];
82+
for (let i = 0; i < 4; i++) {
83+
const items = await engine.dequeueFromMasterQueue({
84+
consumerId: "test_12345",
85+
masterQueue: "main",
86+
maxRunCount: 1,
87+
});
88+
dequeue.push(...items);
89+
}
8590
expect(dequeue.length).toBe(4);
8691
expect(dequeue[0].run.friendlyId).toBe(runs[4].friendlyId);
8792
expect(dequeue[1].run.friendlyId).toBe(runs[3].friendlyId);
@@ -175,11 +180,16 @@ describe("RunEngine priority", () => {
175180
expect(queueLength).toBe(queueTimestamps.length);
176181

177182
//dequeue (expect 4 items because of the negative priority)
178-
const dequeue = await engine.dequeueFromMasterQueue({
179-
consumerId: "test_12345",
180-
masterQueue: "main",
181-
maxRunCount: 20,
182-
});
183+
const dequeue: DequeuedMessage[] = [];
184+
for (let i = 0; i < 5; i++) {
185+
dequeue.push(
186+
...(await engine.dequeueFromMasterQueue({
187+
consumerId: "test_12345",
188+
masterQueue: "main",
189+
maxRunCount: 1,
190+
}))
191+
);
192+
}
183193
expect(dequeue.length).toBe(queueTimestamps.length);
184194
expect(dequeue[0].run.friendlyId).toBe(runs[2].friendlyId);
185195
expect(dequeue[1].run.friendlyId).toBe(runs[3].friendlyId);

0 commit comments

Comments
 (0)