Skip to content

Commit 109bfac

Browse files
committed
Remove exportName from the trigger span names
1 parent b65f225 commit 109bfac

File tree

1 file changed

+8
-40
lines changed

1 file changed

+8
-40
lines changed

packages/trigger-sdk/src/v3/shared.ts

Lines changed: 8 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,8 @@ export function createTask<
129129
id: params.id,
130130
description: params.description,
131131
trigger: async (payload, options) => {
132-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
133-
134132
return await trigger_internal<RunTypes<TIdentifier, TInput, TOutput>>(
135-
taskMetadata && taskMetadata.exportName
136-
? `${taskMetadata.exportName}.trigger()`
137-
: `trigger()`,
133+
"trigger()",
138134
params.id,
139135
payload,
140136
undefined,
@@ -145,12 +141,8 @@ export function createTask<
145141
);
146142
},
147143
batchTrigger: async (items, options) => {
148-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
149-
150144
return await batchTrigger_internal<RunTypes<TIdentifier, TInput, TOutput>>(
151-
taskMetadata && taskMetadata.exportName
152-
? `${taskMetadata.exportName}.batchTrigger()`
153-
: `batchTrigger()`,
145+
"batchTrigger()",
154146
params.id,
155147
items,
156148
options,
@@ -160,13 +152,9 @@ export function createTask<
160152
);
161153
},
162154
triggerAndWait: (payload, options) => {
163-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
164-
165155
return new TaskRunPromise<TIdentifier, TOutput>((resolve, reject) => {
166156
triggerAndWait_internal<TIdentifier, TInput, TOutput>(
167-
taskMetadata && taskMetadata.exportName
168-
? `${taskMetadata.exportName}.triggerAndWait()`
169-
: `triggerAndWait()`,
157+
"triggerAndWait()",
170158
params.id,
171159
payload,
172160
undefined,
@@ -184,12 +172,8 @@ export function createTask<
184172
}, params.id);
185173
},
186174
batchTriggerAndWait: async (items, options) => {
187-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
188-
189175
return await batchTriggerAndWait_internal<TIdentifier, TInput, TOutput>(
190-
taskMetadata && taskMetadata.exportName
191-
? `${taskMetadata.exportName}.batchTriggerAndWait()`
192-
: `batchTriggerAndWait()`,
176+
"batchTriggerAndWait()",
193177
params.id,
194178
items,
195179
undefined,
@@ -276,12 +260,8 @@ export function createSchemaTask<
276260
description: params.description,
277261
schema: params.schema,
278262
trigger: async (payload, options, requestOptions) => {
279-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
280-
281263
return await trigger_internal<RunTypes<TIdentifier, inferSchemaIn<TSchema>, TOutput>>(
282-
taskMetadata && taskMetadata.exportName
283-
? `${taskMetadata.exportName}.trigger()`
284-
: `trigger()`,
264+
"trigger()",
285265
params.id,
286266
payload,
287267
parsePayload,
@@ -293,12 +273,8 @@ export function createSchemaTask<
293273
);
294274
},
295275
batchTrigger: async (items, options, requestOptions) => {
296-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
297-
298276
return await batchTrigger_internal<RunTypes<TIdentifier, inferSchemaIn<TSchema>, TOutput>>(
299-
taskMetadata && taskMetadata.exportName
300-
? `${taskMetadata.exportName}.batchTrigger()`
301-
: `batchTrigger()`,
277+
"batchTrigger()",
302278
params.id,
303279
items,
304280
options,
@@ -308,13 +284,9 @@ export function createSchemaTask<
308284
);
309285
},
310286
triggerAndWait: (payload, options) => {
311-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
312-
313287
return new TaskRunPromise<TIdentifier, TOutput>((resolve, reject) => {
314288
triggerAndWait_internal<TIdentifier, inferSchemaIn<TSchema>, TOutput>(
315-
taskMetadata && taskMetadata.exportName
316-
? `${taskMetadata.exportName}.triggerAndWait()`
317-
: `triggerAndWait()`,
289+
"triggerAndWait()",
318290
params.id,
319291
payload,
320292
parsePayload,
@@ -332,12 +304,8 @@ export function createSchemaTask<
332304
}, params.id);
333305
},
334306
batchTriggerAndWait: async (items, options) => {
335-
const taskMetadata = resourceCatalog.getTaskManifest(params.id);
336-
337307
return await batchTriggerAndWait_internal<TIdentifier, inferSchemaIn<TSchema>, TOutput>(
338-
taskMetadata && taskMetadata.exportName
339-
? `${taskMetadata.exportName}.batchTriggerAndWait()`
340-
: `batchTriggerAndWait()`,
308+
"batchTriggerAndWait()",
341309
params.id,
342310
items,
343311
parsePayload,

0 commit comments

Comments
 (0)