Skip to content

Commit 13cbc9f

Browse files
committed
Fix resolve only external dependencies versions
1 parent aededb9 commit 13cbc9f

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1705,14 +1705,19 @@ export async function resolveRequiredDependencies(
17051705
config: ResolvedConfig
17061706
) {
17071707
return await tracer.startActiveSpan("resolveRequiredDependencies", async (span) => {
1708-
span.setAttribute("resolvablePackageNames", Object.keys(directDependenciesMeta));
1708+
const externalDirectDependenciesVersion = Object.fromEntries(
1709+
Object.entries(directDependenciesMeta)
1710+
.filter(([, { external }]) => external)
1711+
.map(([packageName, { version }]) => [packageName, version])
1712+
);
1713+
span.setAttribute("resolvablePackageNames", Object.keys(externalDirectDependenciesVersion));
17091714

1710-
const missingPackages = Object.entries(directDependenciesMeta)
1711-
.filter(([, pkgMeta]) => !pkgMeta.version)
1715+
const missingPackages = Object.entries(externalDirectDependenciesVersion)
1716+
.filter(([, version]) => !version)
17121717
.map(([name]) => name);
17131718

17141719
span.setAttributes({
1715-
...flattenAttributes(directDependenciesMeta, "resolvedPackageVersions"),
1720+
...flattenAttributes(externalDirectDependenciesVersion, "resolvedPackageVersions"),
17161721
});
17171722
span.setAttribute("missingPackages", missingPackages);
17181723

@@ -1728,7 +1733,7 @@ export async function resolveRequiredDependencies(
17281733
}
17291734
}
17301735

1731-
for (const [packageName, { version }] of Object.entries(directDependenciesMeta)) {
1736+
for (const [packageName, version] of Object.entries(externalDirectDependenciesVersion)) {
17321737
dependencies[packageName] = version;
17331738
}
17341739

@@ -1746,7 +1751,7 @@ export async function resolveRequiredDependencies(
17461751
dependencies[packageParts.name] = packageParts.version;
17471752
continue;
17481753
} else {
1749-
const externalDependencyVersion = directDependenciesMeta[packageParts.name]?.version;
1754+
const externalDependencyVersion = externalDirectDependenciesVersion[packageParts.name];
17501755

17511756
if (externalDependencyVersion) {
17521757
dependencies[packageParts.name] = externalDependencyVersion;

0 commit comments

Comments
 (0)