Skip to content

Commit 15d1806

Browse files
committed
improve webapp socket.io handler error logging
1 parent f2f2963 commit 15d1806

File tree

1 file changed

+28
-6
lines changed

1 file changed

+28
-6
lines changed

apps/webapp/app/v3/handleSocketIo.server.ts

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ function createCoordinatorNamespace(io: Server) {
8787
);
8888

8989
if (!payload) {
90+
logger.error("Failed to retrieve execution payload", message);
9091
return { success: false };
9192
} else {
9293
return { success: true, payload };
@@ -106,6 +107,12 @@ function createCoordinatorNamespace(io: Server) {
106107

107108
return { success: true, lazyPayload: payload };
108109
} catch (error) {
110+
logger.error("Error while creating lazy attempt", {
111+
runId: message.runId,
112+
envId: message.envId,
113+
totalCompletions: message.totalCompletions,
114+
error,
115+
});
109116
return { success: false };
110117
}
111118
},
@@ -152,7 +159,13 @@ function createCoordinatorNamespace(io: Server) {
152159

153160
return { success: !!worker };
154161
} catch (error) {
155-
logger.error("Error while creating worker", { error });
162+
logger.error("Error while creating worker", {
163+
error,
164+
envId: message.envId,
165+
projectRef: message.projectRef,
166+
deploymentId: message.deploymentId,
167+
version: message.version,
168+
});
156169
return { success: false };
157170
}
158171
},
@@ -179,7 +192,10 @@ function createCoordinatorNamespace(io: Server) {
179192

180193
return { success: true, executionPayload: payload };
181194
} catch (error) {
182-
logger.error("Error while creating attempt", { error });
195+
logger.error("Error while creating attempt", {
196+
runId: message.runId,
197+
error,
198+
});
183199
return { success: false };
184200
}
185201
},
@@ -188,8 +204,11 @@ function createCoordinatorNamespace(io: Server) {
188204
const service = new DeploymentIndexFailed();
189205

190206
await service.call(message.deploymentId, message.error);
191-
} catch (e) {
192-
logger.error("Error while processing index failure", { error: e });
207+
} catch (error) {
208+
logger.error("Error while processing index failure", {
209+
deploymentId: message.deploymentId,
210+
error,
211+
});
193212
}
194213
},
195214
RUN_CRASHED: async (message) => {
@@ -200,8 +219,11 @@ function createCoordinatorNamespace(io: Server) {
200219
reason: `${message.error.name}: ${message.error.message}`,
201220
logs: message.error.stack,
202221
});
203-
} catch (e) {
204-
logger.error("Error while processing run failure", { error: e });
222+
} catch (error) {
223+
logger.error("Error while processing run failure", {
224+
runId: message.runId,
225+
error,
226+
});
205227
}
206228
},
207229
},

0 commit comments

Comments
 (0)