Skip to content

Commit 206b9bc

Browse files
committed
Complete the attempt span if it was an OOM error
1 parent c8dec74 commit 206b9bc

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

internal-packages/run-engine/src/engine/index.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2968,6 +2968,22 @@ export class RunEngine {
29682968
const nextAttemptNumber =
29692969
latestSnapshot.attemptNumber === null ? 1 : latestSnapshot.attemptNumber + 1;
29702970

2971+
if (retryResult.wasOOMError) {
2972+
this.eventBus.emit("runAttemptFailed", {
2973+
time: failedAt,
2974+
run: {
2975+
id: runId,
2976+
status: run.status,
2977+
spanId: run.spanId,
2978+
error: completion.error,
2979+
attemptNumber: latestSnapshot.attemptNumber ?? 0,
2980+
createdAt: run.createdAt,
2981+
completedAt: run.completedAt,
2982+
taskEventStore: run.taskEventStore,
2983+
},
2984+
});
2985+
}
2986+
29712987
this.eventBus.emit("runRetryScheduled", {
29722988
time: failedAt,
29732989
run: {

internal-packages/run-engine/src/engine/retrying.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export type RetryOutcome =
3535
method: "queue" | "immediate";
3636
settings: TaskRunExecutionRetry;
3737
machine?: string;
38+
wasOOMError?: boolean;
3839
};
3940

4041
export async function retryOutcomeFromCompletion(
@@ -67,6 +68,7 @@ export async function retryOutcomeFromCompletion(
6768
method: "queue",
6869
machine: oomResult.machine,
6970
settings: { timestamp: Date.now() + delay, delay },
71+
wasOOMError: true,
7072
};
7173
}
7274

0 commit comments

Comments
 (0)