Skip to content

Commit 21e1375

Browse files
committed
Better logs for payload retrieval issues
1 parent d765631 commit 21e1375

File tree

2 files changed

+33
-18
lines changed

2 files changed

+33
-18
lines changed

apps/webapp/app/v3/handleSocketIo.server.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,16 @@ function createCoordinatorNamespace(io: Server) {
104104
);
105105

106106
if (!payload) {
107-
logger.error("Failed to retrieve lazy attempt payload", message);
108-
return { success: false, reason: "Failed to retrieve payload" };
107+
logger.error(
108+
"READY_FOR_LAZY_ATTEMPT: Failed to retrieve lazy attempt payload",
109+
message
110+
);
111+
return { success: false, reason: "READY_FOR_LAZY_ATTEMPT: Failed to retrieve payload" };
109112
}
110113

111114
return { success: true, lazyPayload: payload };
112115
} catch (error) {
113-
logger.error("Error while creating lazy attempt", {
116+
logger.error("READY_FOR_LAZY_ATTEMPT: Error while creating lazy attempt", {
114117
runId: message.runId,
115118
envId: message.envId,
116119
totalCompletions: message.totalCompletions,
@@ -207,13 +210,19 @@ function createCoordinatorNamespace(io: Server) {
207210
});
208211

209212
if (!payload) {
210-
logger.error("Failed to retrieve payload after attempt creation", message);
211-
return { success: false, reason: "Failed to retrieve payload" };
213+
logger.error(
214+
"CREATE_TASK_RUN_ATTEMPT: Failed to retrieve payload after attempt creation",
215+
message
216+
);
217+
return {
218+
success: false,
219+
reason: "CREATE_TASK_RUN_ATTEMPT: Failed to retrieve payload",
220+
};
212221
}
213222

214223
return { success: true, executionPayload: payload };
215224
} catch (error) {
216-
logger.error("Error while creating attempt", {
225+
logger.error("CREATE_TASK_RUN_ATTEMPT: Error while creating attempt", {
217226
...message,
218227
error,
219228
});

apps/webapp/app/v3/marqs/sharedQueueConsumer.server.ts

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,18 +1086,21 @@ class SharedQueueTasks {
10861086
});
10871087

10881088
if (!attempt) {
1089-
logger.error("No attempt found", { id });
1089+
logger.error("getExecutionPayloadFromAttempt: No attempt found", { id });
10901090
return;
10911091
}
10921092

10931093
if (!skipStatusChecks) {
10941094
switch (attempt.status) {
10951095
case "CANCELED":
10961096
case "EXECUTING": {
1097-
logger.error("Invalid attempt status for execution payload retrieval", {
1098-
attemptId: id,
1099-
status: attempt.status,
1100-
});
1097+
logger.error(
1098+
"getExecutionPayloadFromAttempt: Invalid attempt status for execution payload retrieval",
1099+
{
1100+
attemptId: id,
1101+
status: attempt.status,
1102+
}
1103+
);
11011104
return;
11021105
}
11031106
}
@@ -1106,19 +1109,22 @@ class SharedQueueTasks {
11061109
case "CANCELED":
11071110
case "EXECUTING":
11081111
case "INTERRUPTED": {
1109-
logger.error("Invalid run status for execution payload retrieval", {
1110-
attemptId: id,
1111-
runId: attempt.taskRunId,
1112-
status: attempt.taskRun.status,
1113-
});
1112+
logger.error(
1113+
"getExecutionPayloadFromAttempt: Invalid run status for execution payload retrieval",
1114+
{
1115+
attemptId: id,
1116+
runId: attempt.taskRunId,
1117+
status: attempt.taskRun.status,
1118+
}
1119+
);
11141120
return;
11151121
}
11161122
}
11171123
}
11181124

11191125
if (setToExecuting) {
11201126
if (isFinalAttemptStatus(attempt.status) || isFinalRunStatus(attempt.taskRun.status)) {
1121-
logger.error("Status already in final state", {
1127+
logger.error("getExecutionPayloadFromAttempt: Status already in final state", {
11221128
attempt: {
11231129
id: attempt.id,
11241130
status: attempt.status,
@@ -1309,7 +1315,7 @@ class SharedQueueTasks {
13091315
},
13101316
});
13111317

1312-
logger.debug("Getting lazy attempt payload for run", {
1318+
logger.debug("getLazyAttemptPayload: Getting lazy attempt payload for run", {
13131319
run,
13141320
attemptCount,
13151321
});

0 commit comments

Comments
 (0)