Skip to content

Commit 27f7132

Browse files
committed
Don’t do the auto-increment inside a transaction, this means triggerTask isn’t inside one
1 parent b6fc68a commit 27f7132

File tree

1 file changed

+11
-17
lines changed

1 file changed

+11
-17
lines changed

apps/webapp/app/services/autoIncrementCounter.server.ts

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,21 @@ export class AutoIncrementCounter {
3131
let performedBackfill = false;
3232

3333
try {
34-
return await $transaction(
35-
client,
36-
async (tx) => {
37-
let newNumber = await this.#increment(key);
34+
let newNumber = await this.#increment(key);
3835

39-
performedIncrement = true;
36+
performedIncrement = true;
4037

41-
if (newNumber === 1 && backfiller) {
42-
const backfilledNumber = await backfiller(key, tx);
38+
if (newNumber === 1 && backfiller) {
39+
const backfilledNumber = await backfiller(key, client);
4340

44-
if (backfilledNumber && backfilledNumber > 1) {
45-
newNumber = backfilledNumber + 1;
46-
await this._redis.set(key, newNumber);
47-
performedBackfill = true;
48-
}
49-
}
41+
if (backfilledNumber && backfilledNumber > 1) {
42+
newNumber = backfilledNumber + 1;
43+
await this._redis.set(key, newNumber);
44+
performedBackfill = true;
45+
}
46+
}
5047

51-
return await callback(newNumber, tx);
52-
},
53-
transactionOptions
54-
);
48+
return await callback(newNumber, client);
5549
} catch (e) {
5650
if (
5751
e instanceof Prisma.PrismaClientKnownRequestError ||

0 commit comments

Comments
 (0)