Skip to content

Commit 2be75bf

Browse files
samejrsamejr
committed
Removes the duplicate Table Row from the table headers in v2
1 parent 3c0639e commit 2be75bf

File tree

6 files changed

+48
-60
lines changed

6 files changed

+48
-60
lines changed

‎apps/webapp/app/components/events/EventsTable.tsx

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,17 @@ export function EventsTable({
5252
return (
5353
<Table>
5454
<TableHeader>
55-
<TableRow>
56-
<TableHeaderCell>Event</TableHeaderCell>
57-
<TableHeaderCell>Env</TableHeaderCell>
58-
<TableHeaderCell>Received Time</TableHeaderCell>
59-
<TableHeaderCell>Delivery Time</TableHeaderCell>
60-
<TableHeaderCell>Delivered</TableHeaderCell>
61-
<TableHeaderCell>Canceled Time</TableHeaderCell>
62-
<TableHeaderCell>Test</TableHeaderCell>
63-
<TableHeaderCell>Runs</TableHeaderCell>
64-
<TableHeaderCell>
65-
<span className="sr-only">Go to page</span>
66-
</TableHeaderCell>
67-
</TableRow>
55+
<TableHeaderCell>Event</TableHeaderCell>
56+
<TableHeaderCell>Env</TableHeaderCell>
57+
<TableHeaderCell>Received Time</TableHeaderCell>
58+
<TableHeaderCell>Delivery Time</TableHeaderCell>
59+
<TableHeaderCell>Delivered</TableHeaderCell>
60+
<TableHeaderCell>Canceled Time</TableHeaderCell>
61+
<TableHeaderCell>Test</TableHeaderCell>
62+
<TableHeaderCell>Runs</TableHeaderCell>
63+
<TableHeaderCell>
64+
<span className="sr-only">Go to page</span>
65+
</TableHeaderCell>
6866
</TableHeader>
6967
<TableBody>
7068
{total === 0 && !hasFilters ? (

‎apps/webapp/app/components/jobs/JobsTable.tsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,13 @@ export function JobsTable({ jobs, noResultsText }: { jobs: ProjectJob[]; noResul
3131
return (
3232
<Table containerClassName="mb-4">
3333
<TableHeader>
34-
<TableRow>
35-
<TableHeaderCell>Job</TableHeaderCell>
36-
<TableHeaderCell>ID</TableHeaderCell>
37-
<TableHeaderCell>Integrations</TableHeaderCell>
38-
<TableHeaderCell>Properties</TableHeaderCell>
39-
<TableHeaderCell>Last run</TableHeaderCell>
40-
<TableHeaderCell>Status</TableHeaderCell>
41-
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
42-
</TableRow>
34+
<TableHeaderCell>Job</TableHeaderCell>
35+
<TableHeaderCell>ID</TableHeaderCell>
36+
<TableHeaderCell>Integrations</TableHeaderCell>
37+
<TableHeaderCell>Properties</TableHeaderCell>
38+
<TableHeaderCell>Last run</TableHeaderCell>
39+
<TableHeaderCell>Status</TableHeaderCell>
40+
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
4341
</TableHeader>
4442
<TableBody>
4543
{jobs.length > 0 ? (

‎apps/webapp/app/components/runs/RunsTable.tsx

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,21 +58,19 @@ export function RunsTable({
5858
return (
5959
<Table>
6060
<TableHeader>
61-
<TableRow>
62-
<TableHeaderCell>Run</TableHeaderCell>
63-
{showJob && <TableHeaderCell>Job</TableHeaderCell>}
64-
<TableHeaderCell>Env</TableHeaderCell>
65-
<TableHeaderCell>Status</TableHeaderCell>
66-
<TableHeaderCell>Started</TableHeaderCell>
67-
<TableHeaderCell>Duration</TableHeaderCell>
68-
<TableHeaderCell>Exec Time</TableHeaderCell>
69-
<TableHeaderCell>Test</TableHeaderCell>
70-
<TableHeaderCell>Version</TableHeaderCell>
71-
<TableHeaderCell>Created at</TableHeaderCell>
72-
<TableHeaderCell>
73-
<span className="sr-only">Go to page</span>
74-
</TableHeaderCell>
75-
</TableRow>
61+
<TableHeaderCell>Run</TableHeaderCell>
62+
{showJob && <TableHeaderCell>Job</TableHeaderCell>}
63+
<TableHeaderCell>Env</TableHeaderCell>
64+
<TableHeaderCell>Status</TableHeaderCell>
65+
<TableHeaderCell>Started</TableHeaderCell>
66+
<TableHeaderCell>Duration</TableHeaderCell>
67+
<TableHeaderCell>Exec Time</TableHeaderCell>
68+
<TableHeaderCell>Test</TableHeaderCell>
69+
<TableHeaderCell>Version</TableHeaderCell>
70+
<TableHeaderCell>Created at</TableHeaderCell>
71+
<TableHeaderCell>
72+
<span className="sr-only">Go to page</span>
73+
</TableHeaderCell>
7674
</TableHeader>
7775
<TableBody>
7876
{total === 0 && !hasFilters ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.http-endpoints.$httpEndpointParam/route.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,12 @@ export default function Page() {
114114
<div className="mb-8">
115115
<Table fullWidth>
116116
<TableHeader>
117-
<TableRow>
118-
<TableHeaderCell>Environment</TableHeaderCell>
119-
<TableHeaderCell>Endpoint URL</TableHeaderCell>
120-
<TableHeaderCell>Secret</TableHeaderCell>
121-
<TableHeaderCell>Source</TableHeaderCell>
122-
<TableHeaderCell>Respond to request?</TableHeaderCell>
123-
<TableHeaderCell alignment="right">Updated</TableHeaderCell>
124-
</TableRow>
117+
<TableHeaderCell>Environment</TableHeaderCell>
118+
<TableHeaderCell>Endpoint URL</TableHeaderCell>
119+
<TableHeaderCell>Secret</TableHeaderCell>
120+
<TableHeaderCell>Source</TableHeaderCell>
121+
<TableHeaderCell>Respond to request?</TableHeaderCell>
122+
<TableHeaderCell alignment="right">Updated</TableHeaderCell>
125123
</TableHeader>
126124
<TableBody>
127125
{httpEndpoint.httpEndpointEnvironments.map((httpEnvironment) => {

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.http-endpoints._index/route.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,11 @@ export default function Page() {
6767
<div className="mb-8">
6868
<Table fullWidth>
6969
<TableHeader>
70-
<TableRow>
71-
<TableHeaderCell>ID</TableHeaderCell>
72-
<TableHeaderCell>Title</TableHeaderCell>
73-
<TableHeaderCell>Updated</TableHeaderCell>
74-
<TableHeaderCell alignment="right">Environments</TableHeaderCell>
75-
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
76-
</TableRow>
70+
<TableHeaderCell>ID</TableHeaderCell>
71+
<TableHeaderCell>Title</TableHeaderCell>
72+
<TableHeaderCell>Updated</TableHeaderCell>
73+
<TableHeaderCell alignment="right">Environments</TableHeaderCell>
74+
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
7775
</TableHeader>
7876
<TableBody>
7977
{httpEndpoints.length > 0 ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.triggers._index/route.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,12 @@ export default function Integrations() {
4949
</Paragraph>
5050
<Table containerClassName="mt-4">
5151
<TableHeader>
52-
<TableRow>
53-
<TableHeaderCell>Integration</TableHeaderCell>
54-
<TableHeaderCell>Dynamic</TableHeaderCell>
55-
<TableHeaderCell>Properties</TableHeaderCell>
56-
<TableHeaderCell>Environment</TableHeaderCell>
57-
<TableHeaderCell>Active</TableHeaderCell>
58-
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
59-
</TableRow>
52+
<TableHeaderCell>Integration</TableHeaderCell>
53+
<TableHeaderCell>Dynamic</TableHeaderCell>
54+
<TableHeaderCell>Properties</TableHeaderCell>
55+
<TableHeaderCell>Environment</TableHeaderCell>
56+
<TableHeaderCell>Active</TableHeaderCell>
57+
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
6058
</TableHeader>
6159
<TableBody>
6260
{triggers.length > 0 ? (

0 commit comments

Comments
 (0)