Skip to content

Commit 3089caf

Browse files
authored
docs: suggest updated vercel-wait action for Atomic deploys (#1771)
1 parent 94fb532 commit 3089caf

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

docs/deployment/atomic-deployment.mdx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,10 @@ jobs:
127127
128128
- name: Wait for vercel deployment (push)
129129
id: wait-for-vercel
130-
uses: ericallam/vercel-wait@main
130+
uses: ludalex/vercel-wait@v1
131131
with:
132132
project-id: ${{ secrets.VERCEL_PROJECT_ID }}
133+
team-id: ${{ secrets.VERCEL_SCOPE_NAME }}
133134
token: ${{ secrets.VERCEL_TOKEN }}
134135
sha: ${{ github.sha }}
135136
@@ -145,12 +146,12 @@ jobs:
145146
env:
146147
VERCEL_DEPLOYMENT_ID: ${{ steps.wait-for-vercel.outputs.deployment-id }}
147148
VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
148-
VERCEL_SCOPE_NAME: "<your team slug>"
149+
VERCEL_SCOPE_NAME: ${{ secrets.VERCEL_SCOPE_NAME }}
149150
```
150151

151152
This workflow does the following:
152153

153-
1. Waits for the Vercel deployment to complete using the `ericallam/vercel-wait` action.
154+
1. Waits for the Vercel deployment to complete using the `ludalex/vercel-wait` action.
154155
2. Deploys the tasks to Trigger.dev using the `npx trigger.dev deploy` command. There's no need to use the `--skip-promotion` flag because we want to promote the deployment.
155156
3. Promotes the Vercel deployment using the `npx vercel promote` command.
156157

@@ -164,8 +165,9 @@ For this workflow to work, you need to set up the following secrets in your GitH
164165
Checkout our [example repo](https://github.com/ericallam/vercel-atomic-deploys) to see this workflow in action.
165166

166167
<Note>
167-
We are using the `ericallam/vercel-wait` action above as a fork of the [official
168+
We are using the `ludalex/vercel-wait` action above as a fork of the [official
168169
tj-actions/vercel-wait](https://github.com/tj-actions/vercel-wait) action because there is a bug
169-
in the official action that exits early if the deployment isn't found in the first check. I've
170-
opened a PR for this issue [here](https://github.com/tj-actions/vercel-wait/pull/106).
170+
in the official action that exits early if the deployment isn't found in the first check and due
171+
to the fact that it supports treating skipped (cancelled) Vercel deployments as valid (on by default).
172+
I've opened a PR for this issue [here](https://github.com/tj-actions/vercel-wait/pull/106).
171173
</Note>

0 commit comments

Comments
 (0)