Fix missing span end

codenem · codenem · commit 390b32fbc51f · 2024-07-17T10:42:33.000+04:00
diff --git a/packages/cli-v3/src/utilities/javascriptProject.ts b/packages/cli-v3/src/utilities/javascriptProject.ts
@@ -111,13 +111,14 @@ export class JavascriptProject {
           });
         } catch (error) {
           recordSpanException(span, error);
-          span.end();
 
           logger.debug(`Failed to resolve internal dependencies using ${command.name}`, {
             error,
           });
 
           throw error;
+        } finally {
+          span.end();
         }
       }
     );

Original file line number	Diff line number	Diff line change
`@@ -111,13 +111,14 @@ export class JavascriptProject {`
`111`	`111`	`});`
`112`	`112`	`} catch (error) {`
`113`	`113`	`recordSpanException(span, error);`
`114`		`- span.end();`
`115`	`114`
`116`	`115`	logger.debug(`Failed to resolve internal dependencies using ${command.name}`, {
`117`	`116`	`error,`
`118`	`117`	`});`
`119`	`118`
`120`	`119`	`throw error;`
	`120`	`+ } finally {`
	`121`	`+ span.end();`
`121`	`122`	`}`
`122`	`123`	`}`
`123`	`124`	`);`