Fix issues with links in terminals that don’t support them. Also skip update check of version starts with 0.0.0

Author: ericallam

packages/cli-v3/src/commands/deploy.ts

@@ -26,7 +26,7 @@ import {
   saveLogs,
 } from "../deploy/logs.js";
 import { buildManifestToJSON } from "../utilities/buildManifest.js";
-import { chalkError, cliLink, prettyError } from "../utilities/cliOutput.js";
+import { chalkError, cliLink, isLinksSupported, prettyError } from "../utilities/cliOutput.js";
 import { loadDotEnvVars } from "../utilities/dotEnv.js";
 import { writeJSONFile } from "../utilities/fileSystem.js";
 import { printStandloneInitialBanner } from "../utilities/initialBanner.js";
@@ -303,7 +303,11 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {
 
   const $spinner = spinner();
 
-  $spinner.start(`Deploying version ${version} ${deploymentLink}`);
+  if (isLinksSupported) {
+    $spinner.start(`Deploying version ${version} ${deploymentLink}`);
+  } else {
+    $spinner.start(`Deploying version ${version}`);
+  }
 
   const selfHostedRegistryHost = deployment.registryHost ?? options.registry;
   const registryHost = selfHostedRegistryHost ?? "registry.trigger.dev";
@@ -419,9 +423,9 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {
   const taskCount = deploymentWithWorker.worker?.tasks.length ?? 0;
 
   outro(
-    `Version ${version} deployed with ${taskCount} detected task${
-      taskCount === 1 ? "" : "s"
-    } | ${deploymentLink} | ${testLink}`
+    `Version ${version} deployed with ${taskCount} detected task${taskCount === 1 ? "" : "s"} ${
+      isLinksSupported ? `| ${deploymentLink} | ${testLink}` : ""
+    }`
   );
 }
 

packages/cli-v3/src/commands/update.ts

@@ -52,6 +52,11 @@ export async function updateTriggerPackages(
   requireUpdate?: boolean
 ): Promise<boolean> {
   let hasOutput = false;
+  const cliVersion = VERSION;
+
+  if (cliVersion.startsWith("0.0.0")) {
+    return false;
+  }
 
   if (!embedded) {
     intro("Updating packages");
@@ -66,7 +71,6 @@ export async function updateTriggerPackages(
     return false;
   }
 
-  const cliVersion = VERSION;
   const newCliVersion = await updateCheck();
 
   if (newCliVersion) {
@@ -93,7 +97,11 @@ export async function updateTriggerPackages(
     const mismatches: Dependency[] = [];
 
     for (const dep of deps) {
-      if (dep.version === targetVersion || dep.version.startsWith("https://pkg.pr.new")) {
+      if (
+        dep.version === targetVersion ||
+        dep.version.startsWith("https://pkg.pr.new") ||
+        dep.version.startsWith("0.0.0")
+      ) {
         continue;
       }
 

packages/cli-v3/src/dev/devOutput.ts

@@ -17,6 +17,7 @@ import {
   chalkWarning,
   chalkWorker,
   cliLink,
+  isLinksSupported,
   prettyError,
   prettyPrintDate,
 } from "../utilities/cliOutput.js";
@@ -50,23 +51,31 @@ export function startDevOutput(options: DevOutputOptions) {
   const backgroundWorkerInitialized = (
     ...[worker]: EventBusEventArgs<"backgroundWorkerInitialized">
   ) => {
+    const logParts: string[] = [];
+
     const testUrl = `${dashboardUrl}/projects/v3/${config.project}/test?environment=dev`;
     const runsUrl = `${dashboardUrl}/projects/v3/${config.project}/runs?envSlug=dev`;
 
     const pipe = chalkGrey("|");
     const bullet = chalkGrey("○");
     const arrow = chalkGrey("->");
 
+    logParts.push(bullet);
+
     const testLink = chalkLink(cliLink("Test tasks", testUrl));
     const runsLink = chalkLink(cliLink("View runs", runsUrl));
 
     const runtime = chalkGrey(`[${worker.build.runtime}]`);
     const workerStarted = chalkGrey("Background worker ready");
     const workerVersion = chalkWorker(worker.serverWorker!.version);
 
-    logger.log(
-      `${bullet} ${workerStarted} ${runtime} ${arrow} ${workerVersion} ${pipe} ${testLink} ${pipe} ${runsLink}`
-    );
+    logParts.push(workerStarted, runtime, arrow, workerVersion);
+
+    if (isLinksSupported) {
+      logParts.push(pipe, testLink, pipe, runsLink);
+    }
+
+    logger.log(logParts.join(" "));
   };
 
   const backgroundWorkerIndexingError = (
@@ -113,9 +122,9 @@ export function startDevOutput(options: DevOutputOptions) {
     const runId = chalkRun(`${execution.run.id}.${execution.attempt.number}`);
 
     logger.log(
-      `${bullet} ${timestampPrefix} ${chalkGrey(
-        "->"
-      )} ${link} ${pipe} ${workerPrefix} ${pipe} ${taskPrefix} ${pipe} ${runId}`
+      `${bullet} ${timestampPrefix} ${chalkGrey("->")} ${
+        isLinksSupported ? `${link} ${pipe}` : ""
+      } ${workerPrefix} ${pipe} ${taskPrefix} ${pipe} ${runId}`
     );
   };
 
@@ -162,9 +171,9 @@ export function startDevOutput(options: DevOutputOptions) {
     const runId = chalkRun(`${execution.run.id}.${execution.attempt.number}`);
 
     logger.log(
-      `${bullet} ${timestampPrefix} ${chalkGrey(
-        "->"
-      )} ${link} ${pipe} ${workerPrefix} ${pipe} ${taskPrefix} ${pipe} ${runId} ${pipe} ${resultText} ${elapsedText}${errorText}`
+      `${bullet} ${timestampPrefix} ${chalkGrey("->")} ${
+        isLinksSupported ? `${link} ${pipe}` : ""
+      } ${workerPrefix} ${pipe} ${taskPrefix} ${pipe} ${runId} ${pipe} ${resultText} ${elapsedText}${errorText}`
     );
   };
 

packages/cli-v3/src/utilities/cliOutput.ts

@@ -4,6 +4,7 @@ import terminalLink, { Options as TerminalLinkOptions } from "terminal-link";
 import { hasTTY } from "std-env";
 
 export const isInteractive = hasTTY;
+export const isLinksSupported = terminalLink.isSupported;
 
 export const green = "#4FFF54";
 export const purple = "#735BF3";

pnpm-lock.yaml

@@ -0,0 +1 @@
+.trigger

references/hello-world/.gitignore

@@ -0,0 +1,12 @@
+{
+  "name": "references-hello-world",
+  "private": true,
+  "type": "module",
+  "devDependencies": {
+    "trigger.dev": "workspace:*",
+    "typescript": "^5.5.4"
+  },
+  "dependencies": {
+    "@trigger.dev/sdk": "0.0.0-prerelease-20240825150620"
+  }
+}

references/hello-world/package.json

@@ -0,0 +1 @@
+export {};

references/hello-world/src/index.ts

@@ -0,0 +1,14 @@
+import { logger, task, wait } from "@trigger.dev/sdk/v3";
+
+export const helloWorldTask = task({
+  id: "hello-world",
+  run: async (payload: any, { ctx }) => {
+    logger.log("Hello, world!", { payload, ctx });
+
+    await wait.for({ seconds: 5 });
+
+    return {
+      message: "Hello, world!",
+    }
+  },
+});

references/hello-world/src/trigger/example.ts

@@ -0,0 +1,16 @@
+import { defineConfig } from "@trigger.dev/sdk/v3";
+
+export default defineConfig({
+  project: "proj_rrkpdguyagvsoktglnod",
+  logLevel: "log",
+  retries: {
+    enabledInDev: true,
+    default: {
+      maxAttempts: 3,
+      minTimeoutInMs: 1000,
+      maxTimeoutInMs: 10000,
+      factor: 2,
+      randomize: true,
+    },
+  },
+});

references/hello-world/trigger.config.ts

@@ -0,0 +1,18 @@
+{
+  "compilerOptions": {
+    "target": "ES2023",
+    "module": "Node16",
+    "moduleResolution": "Node16",
+    "esModuleInterop": true,
+    "strict": true,
+    "skipLibCheck": true,
+    "customConditions": ["@triggerdotdev/source"],
+    "jsx": "preserve",
+    "lib": ["DOM", "DOM.Iterable"],
+    "noEmit": true
+  },
+  "include": [
+    "./src/**/*.ts",
+    "trigger.config.ts"
+  ]
+}