Skip to content

Commit 4b4cd5f

Browse files
committed
Show disconnected message at the end
1 parent 5f29652 commit 4b4cd5f

File tree

1 file changed

+7
-4
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam

1 file changed

+7
-4
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ function TraceView({ run, trace, maximumLiveReloadingSetting, resizable }: Loade
327327
shouldLiveReload={shouldLiveReload}
328328
maximumLiveReloadingSetting={maximumLiveReloadingSetting}
329329
rootRun={run.rootTaskRun}
330+
isCompleted={run.completedAt !== null}
330331
/>
331332
</ResizablePanel>
332333
<ResizableHandle id={resizableSettings.parent.handleId} />
@@ -454,6 +455,7 @@ type TasksTreeViewProps = {
454455
taskIdentifier: string;
455456
spanId: string;
456457
} | null;
458+
isCompleted: boolean;
457459
};
458460

459461
function TasksTreeView({
@@ -468,6 +470,7 @@ function TasksTreeView({
468470
shouldLiveReload,
469471
maximumLiveReloadingSetting,
470472
rootRun,
473+
isCompleted,
471474
}: TasksTreeViewProps) {
472475
const isAdmin = useHasAdminAccess();
473476
const [filterText, setFilterText] = useState("");
@@ -573,7 +576,7 @@ function TasksTreeView({
573576
nodes={nodes}
574577
getNodeProps={getNodeProps}
575578
getTreeProps={getTreeProps}
576-
renderNode={({ node, state }) => (
579+
renderNode={({ node, state, index }) => (
577580
<>
578581
<div
579582
className={cn(
@@ -640,9 +643,9 @@ function TasksTreeView({
640643
</div>
641644
</div>
642645
</div>
643-
{displayEvents.length === 1 && environmentType === "DEVELOPMENT" && (
644-
<ConnectedDevWarning />
645-
)}
646+
{!isCompleted &&
647+
environmentType === "DEVELOPMENT" &&
648+
index === displayEvents.length - 1 && <ConnectedDevWarning />}
646649
</>
647650
)}
648651
onScroll={(scrollTop) => {

0 commit comments

Comments
 (0)