Skip to content

Commit 4c1ee3d

Browse files
committed
fix: run metadata not working when using npx/pnpm dlx
1 parent 8e38db9 commit 4c1ee3d

File tree

4 files changed

+21
-2
lines changed

4 files changed

+21
-2
lines changed

.changeset/hungry-falcons-fix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@trigger.dev/core": patch
3+
---
4+
5+
fix: run metadata not working when using npx/pnpm dlx

packages/core/src/v3/runMetadata/index.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
import { DeserializedJson } from "../../schemas/json.js";
22
import { apiClientManager } from "../apiClientManager-api.js";
33
import { taskContext } from "../task-context-api.js";
4+
import { getGlobal, registerGlobal } from "../utils/globals.js";
45
import { ApiRequestOptions } from "../zodfetch.js";
56

7+
const API_NAME = "run-metadata";
8+
69
export class RunMetadataAPI {
710
private static _instance?: RunMetadataAPI;
8-
private store: Record<string, DeserializedJson> | undefined;
911

1012
private constructor() {}
1113

@@ -17,8 +19,16 @@ export class RunMetadataAPI {
1719
return this._instance;
1820
}
1921

22+
get store(): Record<string, DeserializedJson> | undefined {
23+
return getGlobal(API_NAME);
24+
}
25+
26+
set store(value: Record<string, DeserializedJson> | undefined) {
27+
registerGlobal(API_NAME, value, true);
28+
}
29+
2030
public enterWithMetadata(metadata: Record<string, DeserializedJson>): void {
21-
this.store = metadata;
31+
registerGlobal(API_NAME, metadata);
2232
}
2333

2434
public current(): Record<string, DeserializedJson> | undefined {

packages/core/src/v3/utils/globals.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { DeserializedJson } from "../../schemas/json.js";
12
import { ApiClientConfiguration } from "../apiClientManager/types.js";
23
import { Clock } from "../clock/clock.js";
34
import type { RuntimeManager } from "../runtime/manager.js";
@@ -54,4 +55,5 @@ type TriggerDotDevGlobalAPI = {
5455
["task-catalog"]?: TaskCatalog;
5556
["task-context"]?: TaskContext;
5657
["api-client"]?: ApiClientConfiguration;
58+
["run-metadata"]?: Record<string, DeserializedJson>;
5759
};

references/v3-catalog/src/trigger/runMetadata.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ export const runMetadataTask = task({
1919
export const runMetadataChildTask = task({
2020
id: "run-metadata-child-task",
2121
run: async (payload: any, { ctx }) => {
22+
logger.info("metadata", { metadata: metadata.current() });
23+
2224
await metadata.set("child", "task");
2325

2426
logger.info("metadata", { metadata: metadata.current() });

0 commit comments

Comments
 (0)