Skip to content

Commit 4ccd4b8

Browse files
committed
dev: kill run process on failed cancel attempt
1 parent c87b835 commit 4ccd4b8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

packages/cli-v3/src/entryPoints/dev-run-controller.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,11 +369,15 @@ export class DevRunController {
369369
try {
370370
await this.cancelAttempt();
371371
} catch (error) {
372-
logger.debug("Failed to cancel attempt, shutting down", {
372+
logger.debug("Failed to cancel attempt, killing task run process", {
373373
error,
374374
});
375375

376-
//todo kill the process?
376+
try {
377+
await this.taskRunProcess?.kill("SIGKILL");
378+
} catch (error) {
379+
logger.debug("Failed to cancel attempt, failed to kill task run process", { error });
380+
}
377381

378382
return;
379383
}

0 commit comments

Comments
 (0)