Misc fixes related to error display (#1397)

* Fix execute error handling

* replace internal errors on attempts

* correctly display env var errors while indexing

* display correct errors on crashed attempts

* add changeset

Author: nicktrn

.changeset/sweet-spies-play.md

@@ -0,0 +1,6 @@
+---
+"trigger.dev": patch
+"@trigger.dev/core": patch
+---
+
+Correctly display errors on attempts and during indexing

apps/webapp/app/v3/services/crashTaskRun.server.ts

@@ -97,7 +97,7 @@ export class CrashTaskRunService extends BaseService {
           event: event,
           crashedAt: opts.crashedAt,
           exception: {
-            type: "Worker crashed",
+            type: opts.errorCode ?? "TASK_RUN_CRASHED",
             message: opts.reason,
             stacktrace: opts.logs,
           },
@@ -119,6 +119,7 @@ export class CrashTaskRunService extends BaseService {
         {
           reason: opts.reason,
           logs: opts.logs,
+          code: opts.errorCode,
         }
       );
     }

packages/cli-v3/src/entryPoints/deploy-index-controller.ts

@@ -61,7 +61,7 @@ async function indexDeployment({
     const $env = await cliApiClient.getEnvironmentVariables(projectRef);
 
     if (!$env.success) {
-      throw new Error(`Failed to fetch environment variables: ${env.error}`);
+      throw new Error(`Failed to fetch environment variables: ${$env.error}`);
     }
 
     const workerManifest = await indexWorkerManifest({

packages/cli-v3/src/entryPoints/deploy-run-controller.ts

@@ -784,12 +784,6 @@ class ProdWorker {
               error,
             });
 
-            try {
-              await this._taskRunProcess.cancel();
-            } catch (error) {
-              logger.error("Failed to cancel task run process", { error });
-            }
-
             try {
               await this.#submitAttemptCompletion(execution, {
                 id: execution.run.id,

packages/core/src/v3/errors.ts

@@ -395,6 +395,13 @@ export function exceptionEventEnhancer(
       }
       break;
     }
+    case TaskRunErrorCodes.TASK_PROCESS_MAYBE_OOM_KILLED:
+    case TaskRunErrorCodes.TASK_PROCESS_OOM_KILLED: {
+      return {
+        ...exception,
+        ...prettyInternalErrors[exception.type],
+      };
+    }
   }
 
   return exception;