Skip to content

Commit 56095a8

Browse files
committed
rename import payload to task input error
1 parent ab86276 commit 56095a8

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

packages/core/src/v3/errors.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,14 +165,14 @@ export function shouldRetryError(error: TaskRunError): boolean {
165165
case "TASK_PROCESS_OOM_KILLED":
166166
case "TASK_PROCESS_MAYBE_OOM_KILLED":
167167
case "TASK_RUN_CANCELLED":
168-
case "TASK_OUTPUT_ERROR":
169168
case "MAX_DURATION_EXCEEDED":
170169
case "DISK_SPACE_EXCEEDED":
171170
return false;
172171

173172
case "GRACEFUL_EXIT_TIMEOUT":
174173
case "HANDLE_ERROR_ERROR":
175-
case "IMPORT_PAYLOAD_ERROR":
174+
case "TASK_INPUT_ERROR":
175+
case "TASK_OUTPUT_ERROR":
176176
case "POD_EVICTED":
177177
case "POD_UNKNOWN_ERROR":
178178
case "TASK_EXECUTION_ABORTED":

packages/core/src/v3/schemas/common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export const TaskRunInternalError = z.object({
9494
"TASK_PROCESS_OOM_KILLED",
9595
"TASK_PROCESS_MAYBE_OOM_KILLED",
9696
"TASK_RUN_CANCELLED",
97+
"TASK_INPUT_ERROR",
9798
"TASK_OUTPUT_ERROR",
9899
"HANDLE_ERROR_ERROR",
99100
"GRACEFUL_EXIT_TIMEOUT",
@@ -103,7 +104,6 @@ export const TaskRunInternalError = z.object({
103104
"DISK_SPACE_EXCEEDED",
104105
"POD_EVICTED",
105106
"POD_UNKNOWN_ERROR",
106-
"IMPORT_PAYLOAD_ERROR",
107107
]),
108108
message: z.string().optional(),
109109
stackTrace: z.string().optional(),

packages/core/src/v3/workers/taskExecutor.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -93,22 +93,22 @@ export class TaskExecutor {
9393
try {
9494
const payloadPacket = await conditionallyImportPacket(originalPacket, this._tracer);
9595
parsedPayload = await parsePacket(payloadPacket);
96-
} catch (packetError) {
97-
recordSpanException(span, packetError);
96+
} catch (inputError) {
97+
recordSpanException(span, inputError);
9898

9999
return {
100100
ok: false,
101101
id: execution.run.id,
102102
error: {
103103
type: "INTERNAL_ERROR",
104-
code: TaskRunErrorCodes.IMPORT_PAYLOAD_ERROR,
104+
code: TaskRunErrorCodes.TASK_INPUT_ERROR,
105105
message:
106-
packetError instanceof Error
107-
? `${packetError.name}: ${packetError.message}`
108-
: typeof packetError === "string"
109-
? packetError
106+
inputError instanceof Error
107+
? `${inputError.name}: ${inputError.message}`
108+
: typeof inputError === "string"
109+
? inputError
110110
: undefined,
111-
stackTrace: packetError instanceof Error ? packetError.stack : undefined,
111+
stackTrace: inputError instanceof Error ? inputError.stack : undefined,
112112
},
113113
} satisfies TaskRunExecutionResult;
114114
}
@@ -151,8 +151,8 @@ export class TaskExecutor {
151151
output: finalOutput.data,
152152
outputType: finalOutput.dataType,
153153
} satisfies TaskRunExecutionResult;
154-
} catch (stringifyError) {
155-
recordSpanException(span, stringifyError);
154+
} catch (outputError) {
155+
recordSpanException(span, outputError);
156156

157157
return {
158158
ok: false,
@@ -161,10 +161,10 @@ export class TaskExecutor {
161161
type: "INTERNAL_ERROR",
162162
code: TaskRunErrorCodes.TASK_OUTPUT_ERROR,
163163
message:
164-
stringifyError instanceof Error
165-
? stringifyError.message
166-
: typeof stringifyError === "string"
167-
? stringifyError
164+
outputError instanceof Error
165+
? outputError.message
166+
: typeof outputError === "string"
167+
? outputError
168168
: undefined,
169169
},
170170
} satisfies TaskRunExecutionResult;

0 commit comments

Comments
 (0)