Revert "dev cli sends regular pings to keep connection alive"

This reverts commit 9a6a7a2.

Author: nicktrn

apps/webapp/app/v3/authenticatedSocketConnection.server.ts

@@ -126,13 +126,6 @@ export class AuthenticatedSocketConnection {
             }
           }
         },
-        PING: async () => {
-          logger.debug("[AuthenticatedSocketConnection] Received ping", {
-            id: this.id,
-            envId: this.authenticatedEnv.id,
-          });
-          await this._sender.send("PONG", {});
-        },
       },
     });
   }

packages/cli-v3/src/commands/dev.tsx

@@ -293,65 +293,9 @@ function useDev({
       `${dashboardUrl}/projects/v3/${config.project}`
     );
 
-    const messageHandler = new ZodMessageHandler({
-      schema: serverWebsocketMessages,
-      messages: {
-        SERVER_READY: async (payload) => {
-          for (const worker of backgroundWorkerCoordinator.currentWorkers) {
-            await sender.send("READY_FOR_TASKS", {
-              backgroundWorkerId: worker.id,
-              inProgressRuns: worker.worker.inProgressRuns,
-            });
-          }
-        },
-        BACKGROUND_WORKER_MESSAGE: async (payload) => {
-          await backgroundWorkerCoordinator.handleMessage(payload.backgroundWorkerId, payload.data);
-        },
-        PONG: async () => {
-          logger.debug("Received pong", { timestamp: Date.now() });
-        },
-      },
-    });
-
-    websocket.addEventListener("message", async (event) => {
-      const data = JSON.parse(
-        typeof event.data === "string" ? event.data : new TextDecoder("utf-8").decode(event.data)
-      );
-
-      await messageHandler.handleMessage(data);
-    });
-
-    const ping = new WebsocketPing({
-      callback: async () => {
-        if (websocket.readyState !== WebSocket.OPEN) {
-          logger.debug("Websocket not open, skipping ping");
-          return;
-        }
-
-        logger.debug("Sending ping", { timestamp: Date.now() });
-
-        await sender.send("PING", {});
-      },
-    });
-
-    websocket.addEventListener("open", async (event) => {
-      logger.debug("Websocket opened", { event });
-
-      ping.start();
-    });
-
-    websocket.addEventListener("close", (event) => {
-      logger.debug("Websocket closed", { event });
-
-      ping.stop();
-    });
-
-    websocket.addEventListener("error", (event) => {
-      logger.log(`${chalkError("Websocket Error:")} ${event.error.message}`);
-      logger.debug("Websocket error", { event, rawError: event.error });
-
-      ping.stop();
-    });
+    websocket.addEventListener("open", async (event) => {});
+    websocket.addEventListener("close", (event) => {});
+    websocket.addEventListener("error", (event) => {});
 
     // This is the deprecated task heart beat that uses the friendly attempt ID
     // It will only be used if the worker does not support lazy attempts
@@ -417,6 +361,34 @@ function useDev({
       });
     });
 
+    websocket.addEventListener("message", async (event) => {
+      const data = JSON.parse(
+        typeof event.data === "string" ? event.data : new TextDecoder("utf-8").decode(event.data)
+      );
+
+      const messageHandler = new ZodMessageHandler({
+        schema: serverWebsocketMessages,
+        messages: {
+          SERVER_READY: async (payload) => {
+            for (const worker of backgroundWorkerCoordinator.currentWorkers) {
+              await sender.send("READY_FOR_TASKS", {
+                backgroundWorkerId: worker.id,
+                inProgressRuns: worker.worker.inProgressRuns,
+              });
+            }
+          },
+          BACKGROUND_WORKER_MESSAGE: async (payload) => {
+            await backgroundWorkerCoordinator.handleMessage(
+              payload.backgroundWorkerId,
+              payload.data
+            );
+          },
+        },
+      });
+
+      await messageHandler.handleMessage(data);
+    });
+
     let ctx: BuildContext | undefined;
 
     let firstBuild = true;
@@ -1000,34 +972,3 @@ function createResolveEnvironmentVariablesFunction(configModule?: any) {
     return resolvedEnvVars;
   };
 }
-
-type WebsocketPingOptions = {
-  callback: () => Promise<void>;
-  pingIntervalInMs?: number;
-};
-
-class WebsocketPing {
-  private _callback: () => Promise<void>;
-  private _pingIntervalInMs: number;
-  private _nextPingIteration: NodeJS.Timeout | undefined;
-
-  constructor(opts: WebsocketPingOptions) {
-    this._callback = opts.callback;
-    this._pingIntervalInMs = opts.pingIntervalInMs ?? 45_000;
-    this._nextPingIteration = undefined;
-  }
-
-  start() {
-    this.#sendPing();
-  }
-
-  stop() {
-    clearTimeout(this._nextPingIteration);
-  }
-
-  #sendPing = async () => {
-    await this._callback();
-
-    this._nextPingIteration = setTimeout(this.#sendPing, this._pingIntervalInMs);
-  };
-}

packages/core/src/v3/schemas/messages.ts

@@ -57,9 +57,6 @@ export const serverWebsocketMessages = {
     backgroundWorkerId: z.string(),
     data: BackgroundWorkerServerMessages,
   }),
-  PONG: z.object({
-    version: z.literal("v1").default("v1"),
-  }),
 };
 
 export const BackgroundWorkerClientMessages = z.discriminatedUnion("type", [
@@ -111,9 +108,6 @@ export const clientWebsocketMessages = {
     backgroundWorkerId: z.string(),
     data: BackgroundWorkerClientMessages,
   }),
-  PING: z.object({
-    version: z.literal("v1").default("v1"),
-  }),
 };
 
 export const workerToChildMessages = {