Skip to content

Commit 5aeeb7d

Browse files
committed
separate project id field
1 parent 47f7819 commit 5aeeb7d

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

apps/webapp/app/routes/admin.api.v1.workers.ts

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { WorkerGroupService } from "~/v3/services/worker/workerGroupService.serv
99
const RequestBodySchema = z.object({
1010
name: z.string().optional(),
1111
description: z.string().optional(),
12-
makeDefaultForProjectId: z.string().optional(),
12+
projectId: z.string().optional(),
13+
makeDefaultForProject: z.boolean().default(false),
1314
removeDefaultFromProject: z.boolean().default(false),
1415
});
1516

@@ -37,21 +38,20 @@ export async function action({ request }: ActionFunctionArgs) {
3738

3839
try {
3940
const rawBody = await request.json();
40-
const { name, description, makeDefaultForProjectId, removeDefaultFromProject } =
41+
const { name, description, projectId, makeDefaultForProject, removeDefaultFromProject } =
4142
RequestBodySchema.parse(rawBody ?? {});
4243

4344
if (removeDefaultFromProject) {
44-
if (!makeDefaultForProjectId) {
45+
if (!projectId) {
4546
return json(
4647
{
47-
error:
48-
"makeDefaultForProjectId is required to remove default worker group from project",
48+
error: "projectId is required to remove default worker group from project",
4949
},
5050
{ status: 400 }
5151
);
5252
}
5353

54-
const updated = await removeDefaultWorkerGroupFromProject(makeDefaultForProjectId);
54+
const updated = await removeDefaultWorkerGroupFromProject(projectId);
5555

5656
if (!updated.success) {
5757
return json(
@@ -76,18 +76,22 @@ export async function action({ request }: ActionFunctionArgs) {
7676
if (!existingWorkerGroup) {
7777
const { workerGroup, token } = await createWorkerGroup(name, description);
7878

79-
if (!makeDefaultForProjectId) {
79+
if (!makeDefaultForProject) {
8080
return json({
8181
outcome: "created new worker group",
8282
token,
8383
workerGroup,
8484
});
8585
}
8686

87-
const updated = await setWorkerGroupAsDefaultForProject(
88-
workerGroup.id,
89-
makeDefaultForProjectId
90-
);
87+
if (!projectId) {
88+
return json(
89+
{ error: "projectId is required to set worker group as default for project" },
90+
{ status: 400 }
91+
);
92+
}
93+
94+
const updated = await setWorkerGroupAsDefaultForProject(workerGroup.id, projectId);
9195

9296
if (!updated.success) {
9397
return json({ error: updated.error }, { status: 400 });
@@ -101,7 +105,7 @@ export async function action({ request }: ActionFunctionArgs) {
101105
});
102106
}
103107

104-
if (!makeDefaultForProjectId) {
108+
if (!makeDefaultForProject) {
105109
return json(
106110
{
107111
error: "worker group already exists",
@@ -111,10 +115,14 @@ export async function action({ request }: ActionFunctionArgs) {
111115
);
112116
}
113117

114-
const updated = await setWorkerGroupAsDefaultForProject(
115-
existingWorkerGroup.id,
116-
makeDefaultForProjectId
117-
);
118+
if (!projectId) {
119+
return json(
120+
{ error: "projectId is required to set worker group as default for project" },
121+
{ status: 400 }
122+
);
123+
}
124+
125+
const updated = await setWorkerGroupAsDefaultForProject(existingWorkerGroup.id, projectId);
118126

119127
if (!updated.success) {
120128
return json(

0 commit comments

Comments
 (0)