Skip to content

Commit 5c262fd

Browse files
committed
Revert "prevent creating checkpoints for outdated batch waits"
This reverts commit f2b5c2a.
1 parent 89ec5c8 commit 5c262fd

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

apps/webapp/app/v3/services/createCheckpoint.server.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@ export class CreateCheckpointService extends BaseService {
122122
logger.error("CreateCheckpointService: Checkpoint not for most recent child run", {
123123
attemptId: attempt.id,
124124
runId: attempt.taskRunId,
125-
lastChild: lastChildRun.friendlyId,
126-
checkpointFor: reason.friendlyId,
127125
params,
128126
});
129127

@@ -136,33 +134,6 @@ export class CreateCheckpointService extends BaseService {
136134
break;
137135
}
138136
case "WAIT_FOR_BATCH": {
139-
const lastChildRun = attempt.taskRun.childRuns[0];
140-
141-
if (!lastChildRun) {
142-
logger.warn("CreateCheckpointService: No child runs, creating checkpoint regardless", {
143-
attemptId: attempt.id,
144-
runId: attempt.taskRunId,
145-
params,
146-
});
147-
148-
break;
149-
}
150-
151-
if (!reason.runFriendlyIds.includes(lastChildRun.friendlyId)) {
152-
logger.error("CreateCheckpointService: Checkpoint not for most recent batch", {
153-
attemptId: attempt.id,
154-
runId: attempt.taskRunId,
155-
lastChild: lastChildRun.friendlyId,
156-
checkpointFor: reason.runFriendlyIds,
157-
params,
158-
});
159-
160-
return {
161-
success: false,
162-
keepRunAlive: true,
163-
};
164-
}
165-
166137
break;
167138
}
168139
default: {

0 commit comments

Comments
 (0)