Skip to content

Commit 601cded

Browse files
committed
fix text inputs on windows
1 parent b79a4fc commit 601cded

File tree

8 files changed

+31
-10
lines changed

8 files changed

+31
-10
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intro, log, outro, spinner } from "@clack/prompts";
1+
import { intro, log, outro } from "@clack/prompts";
22
import { depot } from "@depot/cli";
33
import { context, trace } from "@opentelemetry/api";
44
import {
@@ -56,7 +56,7 @@ import {
5656
import { safeJsonParse } from "../utilities/safeJsonParse";
5757
import { JavascriptProject } from "../utilities/javascriptProject";
5858
import { cliRootPath } from "../utilities/resolveInternalFilePath";
59-
import { escapeImportPath } from "../utilities/windows";
59+
import { escapeImportPath, spinner } from "../utilities/windows";
6060

6161
const DeployCommandOptions = CommonCommandOptions.extend({
6262
skipTypecheck: z.boolean().default(false),

packages/cli-v3/src/commands/init.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intro, isCancel, log, outro, select, spinner, text } from "@clack/prompts";
1+
import { intro, isCancel, log, outro, select, text } from "@clack/prompts";
22
import { context, trace } from "@opentelemetry/api";
33
import {
44
GetProjectResponseBody,
@@ -32,6 +32,7 @@ import { printStandloneInitialBanner } from "../utilities/initialBanner.js";
3232
import { logger } from "../utilities/logger";
3333
import { cliRootPath } from "../utilities/resolveInternalFilePath";
3434
import { login } from "./login";
35+
import { spinner } from "../utilities/windows";
3536

3637
const InitCommandOptions = CommonCommandOptions.extend({
3738
projectRef: z.string().optional(),
@@ -185,9 +186,8 @@ async function _initCommand(dir: string, options: InitCommandOptions) {
185186
async function createTriggerDir(dir: string, options: InitCommandOptions) {
186187
return await tracer.startActiveSpan("createTriggerDir", async (span) => {
187188
try {
188-
const defaultValue = join(dir, "src", "trigger-2");
189+
const defaultValue = join(dir, "src", "trigger");
189190

190-
// FIXME: (windows) Text prompts do not accept any user input
191191
const location = await text({
192192
message: "Where would you like to create the Trigger.dev directory?",
193193
defaultValue: defaultValue,

packages/cli-v3/src/commands/login.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intro, log, outro, select, spinner } from "@clack/prompts";
1+
import { intro, log, outro, select } from "@clack/prompts";
22
import { recordSpanException } from "@trigger.dev/core/v3";
33
import { Command } from "commander";
44
import open from "open";
@@ -20,6 +20,7 @@ import { printInitialBanner } from "../utilities/initialBanner.js";
2020
import { LoginResult } from "../utilities/session.js";
2121
import { whoAmI } from "./whoami.js";
2222
import { logger } from "../utilities/logger.js";
23+
import { spinner } from "../utilities/windows.js";
2324

2425
export const LoginCommandOptions = CommonCommandOptions.extend({
2526
apiUrl: z.string(),

packages/cli-v3/src/commands/update.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
import { confirm, spinner } from "@clack/prompts";
1+
import { confirm } from "@clack/prompts";
22
import { RunOptions, run } from "npm-check-updates";
33
import path from "path";
44
import { z } from "zod";
55
import { chalkError, chalkSuccess } from "../utilities/cliOutput.js";
66
import { readJSONFileSync, writeJSONFile } from "../utilities/fileSystem.js";
77
import { installDependencies } from "../utilities/installDependencies.js";
8+
import { spinner } from "../utilities/windows.js";
89

910
export const UpdateCommandOptionsSchema = z.object({
1011
to: z.string().optional(),

packages/cli-v3/src/commands/whoami.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intro, note, spinner } from "@clack/prompts";
1+
import { intro, note } from "@clack/prompts";
22
import { chalkLink } from "../utilities/cliOutput.js";
33
import { logger } from "../utilities/logger.js";
44
import { isLoggedIn } from "../utilities/session.js";
@@ -12,6 +12,7 @@ import {
1212
} from "../cli/common.js";
1313
import { z } from "zod";
1414
import { CliApiClient } from "../apiClient.js";
15+
import { spinner } from "../utilities/windows.js";
1516

1617
type WhoAmIResult =
1718
| {

packages/cli-v3/src/utilities/initialBanner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { spinner } from "@clack/prompts";
21
import chalk from "chalk";
32
import type { Result } from "update-check";
43
import checkForUpdate from "update-check";
54
import pkg from "../../package.json";
65
import { chalkGrey, chalkRun, chalkTask, chalkWorker, green, logo } from "./cliOutput.js";
76
import { getVersion } from "./getVersion.js";
87
import { logger } from "./logger.js";
8+
import { spinner } from "./windows";
99

1010
export async function printInitialBanner(performUpdateCheck = true) {
1111
const packageVersion = getVersion();

packages/cli-v3/src/utilities/installDependencies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { spinner } from "@clack/prompts";
21
import chalk from "chalk";
32
import { execa } from "execa";
43
import { getUserPackageManager, type PackageManager } from "./getUserPackageManager.js";
54
import { logger } from "./logger.js";
5+
import { spinner } from "./windows.js";
66

77
export async function installDependencies(projectDir: string) {
88
logger.info("Installing dependencies...");
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
1+
import { log, spinner as clackSpinner } from "@clack/prompts";
2+
13
export const isWindows = process.platform === "win32";
24

35
export function escapeImportPath(path: string) {
46
return isWindows ? path.replaceAll("\\", "\\\\") : path;
57
}
8+
9+
const ballmerSpinner = () => ({
10+
start: (msg?: string): void => {
11+
log.step(msg ?? "");
12+
},
13+
stop: (msg?: string, code?: number): void => {
14+
log.message(msg ?? "");
15+
},
16+
message: (msg?: string): void => {
17+
log.message(msg ?? "");
18+
},
19+
});
20+
21+
// This will become unecessary with the next clack release, the bug was fixed here:
22+
// https://github.com/natemoo-re/clack/pull/182
23+
export const spinner = () => (isWindows ? ballmerSpinner() : clackSpinner());

0 commit comments

Comments
 (0)