Remove setting the invisibility timeout because it’s already done in the dequeue Lua script

matt-aitken · matt-aitken · commit 65cc779e10b3 · 2025-04-24T10:52:36.000+01:00
diff --git a/packages/redis-worker/src/queue.ts b/packages/redis-worker/src/queue.ts
@@ -130,6 +130,7 @@ export class SimpleQueue<TMessageCatalog extends MessageCatalogSchema> {
       throw e;
     }
   }
+
   async dequeue(count: number = 1): Promise<Array<QueueItem<TMessageCatalog>>> {
     const now = Date.now();
 
@@ -179,9 +180,6 @@ export class SimpleQueue<TMessageCatalog extends MessageCatalogSchema> {
         }
 
         const visibilityTimeoutMs = parsedItem.visibilityTimeoutMs as number;
-        const invisibleUntil = now + visibilityTimeoutMs;
-
-        await this.redis.zadd(`queue`, invisibleUntil, id);
 
         dequeuedItems.push({
           id,

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,7 @@ export class SimpleQueue<TMessageCatalog extends MessageCatalogSchema> {`
`130`	`130`	`throw e;`
`131`	`131`	`}`
`132`	`132`	`}`
	`133`	`+`
`133`	`134`	`async dequeue(count: number = 1): Promise<Array<QueueItem<TMessageCatalog>>> {`
`134`	`135`	`const now = Date.now();`
`135`	`136`
`@@ -179,9 +180,6 @@ export class SimpleQueue<TMessageCatalog extends MessageCatalogSchema> {`
`179`	`180`	`}`
`180`	`181`
`181`	`182`	`const visibilityTimeoutMs = parsedItem.visibilityTimeoutMs as number;`
`182`		`- const invisibleUntil = now + visibilityTimeoutMs;`
`183`		`-`
`184`		- await this.redis.zadd(`queue`, invisibleUntil, id);
`185`	`183`
`186`	`184`	`dequeuedItems.push({`
`187`	`185`	`id,`