Skip to content

Commit 68f8aba

Browse files
committed
Improve the new run engine Trigger/Batch trigger service class names
1 parent 82251e2 commit 68f8aba

File tree

5 files changed

+608
-16
lines changed

5 files changed

+608
-16
lines changed

apps/webapp/app/routes/api.v2.tasks.batch.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ import { logger } from "~/services/logger.server";
1010
import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
1111
import { ServiceValidationError } from "~/v3/services/baseService.server";
1212
import { BatchProcessingStrategy } from "~/v3/services/batchTriggerV3.server";
13-
import { BatchTriggerV4Service } from "~/v3/services/batchTriggerV4.server";
1413
import { OutOfEntitlementError } from "~/v3/services/triggerTask.server";
1514
import { HeadersSchema } from "./api.v1.tasks.$taskId.trigger";
15+
import { RunEngineBatchTriggerService } from "~/runEngine/services/batchTrigger.server";
1616

1717
const { action, loader } = createActionApiRoute(
1818
{
@@ -74,7 +74,7 @@ const { action, loader } = createActionApiRoute(
7474
? { traceparent, tracestate }
7575
: undefined;
7676

77-
const service = new BatchTriggerV4Service(batchProcessingStrategy ?? undefined);
77+
const service = new RunEngineBatchTriggerService(batchProcessingStrategy ?? undefined);
7878

7979
try {
8080
const batch = await service.call(authentication.environment, body, {

apps/webapp/app/v3/services/batchTriggerV4.server.ts renamed to apps/webapp/app/runEngine/services/batchTrigger.server.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ import { AuthenticatedEnvironment } from "~/services/apiAuth.server";
1515
import { logger } from "~/services/logger.server";
1616
import { getEntitlement } from "~/services/platform.v3.server";
1717
import { workerQueue } from "~/services/worker.server";
18-
import { downloadPacketFromObjectStore, uploadPacketToObjectStore } from "../r2.server";
19-
import { startActiveSpan } from "../tracer.server";
20-
import { ServiceValidationError, WithRunEngine } from "./baseService.server";
21-
import { OutOfEntitlementError, TriggerTaskService } from "./triggerTask.server";
18+
import { downloadPacketFromObjectStore, uploadPacketToObjectStore } from "../../v3/r2.server";
19+
import { startActiveSpan } from "../../v3/tracer.server";
20+
import { ServiceValidationError, WithRunEngine } from "../../v3/services/baseService.server";
21+
import { OutOfEntitlementError, TriggerTaskService } from "../../v3/services/triggerTask.server";
2222

2323
const PROCESSING_BATCH_SIZE = 50;
2424
const ASYNC_BATCH_PROCESS_SIZE_THRESHOLD = 20;
@@ -49,7 +49,7 @@ export type BatchTriggerTaskServiceOptions = {
4949
/**
5050
* Larger batches, used in Run Engine v2
5151
*/
52-
export class BatchTriggerV4Service extends WithRunEngine {
52+
export class RunEngineBatchTriggerService extends WithRunEngine {
5353
private _batchProcessingStrategy: BatchProcessingStrategy;
5454

5555
constructor(
@@ -643,7 +643,7 @@ export class BatchTriggerV4Service extends WithRunEngine {
643643
}
644644

645645
async #enqueueBatchTaskRun(options: BatchProcessingOptions, tx?: PrismaClientOrTransaction) {
646-
await workerQueue.enqueue("v3.processBatchTaskRunV3", options, {
646+
await workerQueue.enqueue("runengine.processBatchTaskRun", options, {
647647
tx,
648648
jobKey: `BatchTriggerV3Service.process:${options.batchId}:${options.processingId}`,
649649
});

0 commit comments

Comments
 (0)