Edge cases

Author: codenem

packages/cli-v3/e2e/fixtures/compile-monorepo-packages/pnpm-lock.yaml

@@ -1165,15 +1165,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"infisical-sdk@workspace:.":
-  version: 0.0.0-use.local
-  resolution: "infisical-sdk@workspace:."
-  dependencies:
-    "@infisical/sdk": "npm:^2.2.3"
-    "@trigger.dev/sdk": "npm:3.0.0-beta.33"
-  languageName: unknown
-  linkType: soft
-
 "ini@npm:^1.3.2":
   version: 1.3.8
   resolution: "ini@npm:1.3.8"

packages/cli-v3/e2e/fixtures/config-infisical-sdk/yarn.lock

@@ -1 +1,2 @@
 legacy-peer-deps=true
+auto-install-peers=false

packages/cli-v3/e2e/fixtures/resolve-legacy-peer-deps/.npmrc

@@ -51,7 +51,7 @@ logger.loggerLevel = options.logLevel;
 
 if (testCases.length > 0) {
   describe.concurrent("bundling", async () => {
-    beforeEach<E2EFixtureTest>(async ({ fixtureDir, packageManager, workspaceDir }) => {
+    beforeEach<E2EFixtureTest>(async ({ fixtureDir, packageManager, skip, workspaceDir }) => {
       await rimraf(join(workspaceDir, "**/node_modules"), {
         glob: true,
       });
@@ -75,6 +75,13 @@ if (testCases.length > 0) {
         }
       }
 
+      if (
+        options.packageManager &&
+        !existsSync(resolve(fixtureDir, LOCKFILES[options.packageManager]))
+      ) {
+        skip();
+      }
+
       await installFixtureDeps({ fixtureDir, packageManager, workspaceDir });
     }, TIMEOUT);
 
@@ -112,10 +119,8 @@ if (testCases.length > 0) {
         `fixture '${testCase.id}'`,
         { timeout: TIMEOUT },
         async ({
-          fixtureDir,
           packageManager,
           resolveEnv,
-          skip,
           skipTypecheck,
           tempDir,
           wantCompilationError,
@@ -126,13 +131,6 @@ if (testCases.length > 0) {
           wantWorkerError,
           workspaceDir,
         }) => {
-          if (
-            options.packageManager &&
-            !existsSync(resolve(fixtureDir, LOCKFILES[options.packageManager]))
-          ) {
-            skip();
-          }
-
           let resolvedConfig: ReadConfigResult;
           const configExpect = expect(
             (async () => {

packages/cli-v3/e2e/fixtures/resolve-legacy-peer-deps/pnpm-lock.yaml

@@ -483,12 +483,14 @@ class NPMCommands implements PackageManagerCommands {
     return results;
   }
 
-  async extractDirectDependenciesMeta(options: PackageManagerOptions) {
+  async extractDirectDependenciesMeta(
+    options: PackageManagerOptions
+  ): Promise<Record<string, DependencyMeta>> {
     const result = await this.#listDirectDependencies(options);
 
     logger.debug(`Extracting direct dependencies metadata using ${this.name}`);
 
-    return this.#flattenDependenciesMeta(result.dependencies);
+    return result.dependencies ? this.#flattenDependenciesMeta(result.dependencies) : {};
   }
 
   async #listDirectDependencies(options: PackageManagerOptions) {
@@ -546,11 +548,11 @@ class NPMCommands implements PackageManagerCommands {
     let results: Record<string, DependencyMeta> = {};
 
     for (const [name, dep] of Object.entries(dependencies)) {
-      const { version, resolved, dependencies } = dep;
-      results[name] = { version, external: !resolved.startsWith("file:") };
+      const { version, resolved, dependencies: children } = dep;
+      results[name] = { version, external: !!resolved && !resolved.startsWith("file:") };
 
-      if (dependencies) {
-        results = { ...results, ...this.#flattenDependenciesMeta(dependencies) };
+      if (children) {
+        results = { ...results, ...this.#flattenDependenciesMeta(children) };
       }
     }