Skip to content

Commit 8cfa977

Browse files
committed
Remove unused options
1 parent 2144fb7 commit 8cfa977

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

packages/cli-v3/src/utilities/javascriptProject.ts

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,10 @@ export class JavascriptProject {
123123
);
124124
}
125125

126-
async resolveAll(
127-
packageNames: string[],
128-
options?: ResolveOptions
129-
): Promise<Record<string, string>> {
126+
async resolveAll(packageNames: string[]): Promise<Record<string, string>> {
130127
return tracer.startActiveSpan("JavascriptProject.resolveAll", async (span) => {
131128
const externalPackages = packageNames.filter((packageName) => !isBuiltInModule(packageName));
132129

133-
const opts = { allowDev: false, ...options };
134-
135130
const command = await this.#getCommand();
136131

137132
span.setAttributes({
@@ -168,18 +163,6 @@ export class JavascriptProject {
168163

169164
missingPackageVersions[packageName] = packageJsonVersion;
170165
}
171-
172-
if (opts.allowDev) {
173-
const devPackageJsonVersion = this.packageJson.devDependencies?.[packageName];
174-
175-
if (typeof devPackageJsonVersion === "string") {
176-
logger.debug(`Resolved ${packageName} version using devDependencies`, {
177-
devPackageJsonVersion,
178-
});
179-
180-
missingPackageVersions[packageName] = devPackageJsonVersion;
181-
}
182-
}
183166
}
184167

185168
span.setAttributes({

0 commit comments

Comments
 (0)