Skip to content

Commit aa787c2

Browse files
committed
Queues page promise fix
1 parent d8b1144 commit aa787c2

File tree

1 file changed

+15
-16
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues

1 file changed

+15
-16
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
9999
const environmentQueuePresenter = new EnvironmentQueuePresenter();
100100

101101
return typeddefer({
102-
queues,
102+
...queues,
103103
environment: environmentQueuePresenter.call(environment),
104104
});
105105
} catch (error) {
@@ -169,7 +169,7 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
169169
};
170170

171171
export default function Page() {
172-
const { environment, queues } = useTypedLoaderData<typeof loader>();
172+
const { environment, queues, success, pagination, code } = useTypedLoaderData<typeof loader>();
173173

174174
const organization = useOrganization();
175175
const env = useEnvironment();
@@ -255,7 +255,7 @@ export default function Page() {
255255
</Suspense>
256256
</div>
257257

258-
{queues.success ? (
258+
{success ? (
259259
<>
260260
<Table containerClassName="border-t">
261261
<TableHeader>
@@ -282,11 +282,11 @@ export default function Page() {
282282
}
283283
>
284284
<TypedAwait
285-
resolve={Promise.all([queues.queues, environment])}
285+
resolve={Promise.all([queues, environment])}
286286
errorElement={<Paragraph variant="small">Error loading queues</Paragraph>}
287287
>
288-
{([q, environment]) =>
289-
q.length > 0 ? (
288+
{([q, environment]) => {
289+
return q.length > 0 ? (
290290
q.map((queue) => (
291291
<TableRow key={queue.name}>
292292
<TableCell>
@@ -321,13 +321,13 @@ export default function Page() {
321321
) : (
322322
<TableRow>
323323
<TableCell colSpan={5}>
324-
<span className="grid place-items-center py-6 text-text-dimmed">
324+
<div className="grid place-items-center py-6 text-text-dimmed">
325325
No queues found
326-
</span>
326+
</div>
327327
</TableCell>
328328
</TableRow>
329-
)
330-
}
329+
);
330+
}}
331331
</TypedAwait>
332332
</Suspense>
333333
</TableBody>
@@ -336,27 +336,26 @@ export default function Page() {
336336
<div
337337
className={cn(
338338
"grid h-fit max-h-full min-h-full overflow-x-auto",
339-
queues.pagination.totalPages > 1 ? "grid-rows-[1fr_auto]" : "grid-rows-[1fr]"
339+
pagination.totalPages > 1 ? "grid-rows-[1fr_auto]" : "grid-rows-[1fr]"
340340
)}
341341
>
342342
<div
343343
className={cn(
344344
"flex min-h-full",
345-
queues.pagination.totalPages > 1 &&
346-
"justify-end border-t border-grid-dimmed px-2 py-3"
345+
pagination.totalPages > 1 && "justify-end border-t border-grid-dimmed px-2 py-3"
347346
)}
348347
>
349348
<PaginationControls
350-
currentPage={queues.pagination.currentPage}
351-
totalPages={queues.pagination.totalPages}
349+
currentPage={pagination.currentPage}
350+
totalPages={pagination.totalPages}
352351
/>
353352
</div>
354353
</div>
355354
</>
356355
) : (
357356
<div className="grid place-items-center py-6 text-text-dimmed">
358357
<p>
359-
{queues.code === "engine-version"
358+
{code === "engine-version"
360359
? "Please upgrade your engine to v3 to use queues."
361360
: "Something went wrong"}
362361
</p>

0 commit comments

Comments
 (0)