Skip to content

Commit b28fd42

Browse files
committed
Fix for tests that were using the old engine.unblockRunForCreatedBatch() function
1 parent 30644f5 commit b28fd42

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

internal-packages/run-engine/src/engine/tests/batchTriggerAndWait.test.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,6 @@ describe("RunEngine batchTriggerAndWait", () => {
191191
expect(batchWaitpoint?.waitpoint.type).toBe("BATCH");
192192
expect(batchWaitpoint?.waitpoint.completedByBatchId).toBe(batch.id);
193193

194-
await engine.unblockRunForCreatedBatch({
195-
runId: parentRun.id,
196-
batchId: batch.id,
197-
environmentId: authenticatedEnvironment.id,
198-
projectId: authenticatedEnvironment.projectId,
199-
});
200-
201194
//dequeue and start the 1st child
202195
const dequeuedChild = await engine.dequeueFromMasterQueue({
203196
consumerId: "test_12345",
@@ -303,7 +296,7 @@ describe("RunEngine batchTriggerAndWait", () => {
303296
expect(child2WaitpointAfter?.status).toBe("COMPLETED");
304297
expect(child2WaitpointAfter?.output).toBe('{"baz":"qux"}');
305298

306-
await setTimeout(500);
299+
await setTimeout(1_000);
307300

308301
const runWaitpointsAfterSecondChild = await prisma.taskRunWaitpoint.findMany({
309302
where: {
@@ -497,13 +490,6 @@ describe("RunEngine batchTriggerAndWait", () => {
497490
expect(parentAfterBatchChild.snapshot.executionStatus).toBe("EXECUTING_WITH_WAITPOINTS");
498491
expect(parentAfterBatchChild.batch?.id).toBe(batch.id);
499492

500-
await engine.unblockRunForCreatedBatch({
501-
runId: parentRun.id,
502-
batchId: batch.id,
503-
environmentId: authenticatedEnvironment.id,
504-
projectId: authenticatedEnvironment.projectId,
505-
});
506-
507493
//dequeue and start the batch child
508494
const dequeuedBatchChild = await engine.dequeueFromMasterQueue({
509495
consumerId: "test_12345",

internal-packages/run-engine/src/engine/tests/checkpoints.test.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,13 +1166,6 @@ describe("RunEngine checkpoints", () => {
11661166
expect(batchWaitpoint?.waitpoint.type).toBe("BATCH");
11671167
expect(batchWaitpoint?.waitpoint.completedByBatchId).toBe(batch.id);
11681168

1169-
await engine.unblockRunForCreatedBatch({
1170-
runId: parentRun.id,
1171-
batchId: batch.id,
1172-
environmentId: authenticatedEnvironment.id,
1173-
projectId: authenticatedEnvironment.projectId,
1174-
});
1175-
11761169
// Create a checkpoint
11771170
const checkpointResult = await engine.createCheckpoint({
11781171
runId: parentRun.id,

0 commit comments

Comments
 (0)