Skip to content

Commit bc71e2c

Browse files
committed
refactor unrecoverable error emit
1 parent 5e4b4a3 commit bc71e2c

File tree

1 file changed

+24
-35
lines changed

1 file changed

+24
-35
lines changed

packages/cli-v3/src/workers/prod/entry-point.ts

Lines changed: 24 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -231,13 +231,10 @@ class ProdWorker {
231231
if (!this.attemptFriendlyId) {
232232
logger.error("Failed to send wait message, attempt friendly ID not set", { message });
233233

234-
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
235-
version: "v1",
236-
error: {
237-
name: "NoAttemptId",
238-
message: "Attempt ID not set before waiting for duration",
239-
},
240-
});
234+
this.#emitUnrecoverableError(
235+
"NoAttemptId",
236+
"Attempt ID not set before waiting for duration"
237+
);
241238

242239
return;
243240
}
@@ -257,13 +254,7 @@ class ProdWorker {
257254
if (!this.attemptFriendlyId) {
258255
logger.error("Failed to send wait message, attempt friendly ID not set", { message });
259256

260-
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
261-
version: "v1",
262-
error: {
263-
name: "NoAttemptId",
264-
message: "Attempt ID not set before waiting for task",
265-
},
266-
});
257+
this.#emitUnrecoverableError("NoAttemptId", "Attempt ID not set before waiting for task");
267258

268259
return;
269260
}
@@ -283,13 +274,7 @@ class ProdWorker {
283274
if (!this.attemptFriendlyId) {
284275
logger.error("Failed to send wait message, attempt friendly ID not set", { message });
285276

286-
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
287-
version: "v1",
288-
error: {
289-
name: "NoAttemptId",
290-
message: "Attempt ID not set before waiting for batch",
291-
},
292-
});
277+
this.#emitUnrecoverableError("NoAttemptId", "Attempt ID not set before waiting for batch");
293278

294279
return;
295280
}
@@ -598,27 +583,21 @@ class ProdWorker {
598583
if (!this.nextResumeAfter) {
599584
logger.error("Missing next resume reason");
600585

601-
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
602-
version: "v1",
603-
error: {
604-
name: "NoNextResume",
605-
message: "Next resume reason not set while resuming from paused state",
606-
},
607-
});
586+
this.#emitUnrecoverableError(
587+
"NoNextResume",
588+
"Next resume reason not set while resuming from paused state"
589+
);
608590

609591
return;
610592
}
611593

612594
if (!this.attemptFriendlyId) {
613595
logger.error("Missing friendly ID");
614596

615-
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
616-
version: "v1",
617-
error: {
618-
name: "NoAttemptId",
619-
message: "Attempt ID not set while resuming from paused state",
620-
},
621-
});
597+
this.#emitUnrecoverableError(
598+
"NoAttemptId",
599+
"Attempt ID not set while resuming from paused state"
600+
);
622601

623602
return;
624603
}
@@ -939,6 +918,16 @@ class ProdWorker {
939918
};
940919
}
941920

921+
#emitUnrecoverableError(name: string, message: string) {
922+
this.#coordinatorSocket.socket.emit("UNRECOVERABLE_ERROR", {
923+
version: "v1",
924+
error: {
925+
name,
926+
message,
927+
},
928+
});
929+
}
930+
942931
start() {
943932
this.#httpServer.listen(this.#httpPort, this.host);
944933
}

0 commit comments

Comments
 (0)