Skip to content

Commit be23df4

Browse files
committed
Triggered runs table has a max height
1 parent 4ee4963 commit be23df4

File tree

1 file changed

+38
-32
lines changed
  • apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam.spans.$spanParam

1 file changed

+38
-32
lines changed

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam.spans.$spanParam/route.tsx

Lines changed: 38 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -319,38 +319,44 @@ function SpanBody({
319319
<Property.Item>
320320
<div className="flex flex-col gap-1.5">
321321
<Header3>Triggered runs</Header3>
322-
<Table>
323-
<TableHeader>
324-
<TableRow>
325-
<TableHeaderCell>Run #</TableHeaderCell>
326-
<TableHeaderCell>Task</TableHeaderCell>
327-
<TableHeaderCell>Version</TableHeaderCell>
328-
<TableHeaderCell>Created at</TableHeaderCell>
329-
</TableRow>
330-
</TableHeader>
331-
<TableBody>
332-
{span.triggeredRuns.map((run) => {
333-
const path = v3RunSpanPath(
334-
organization,
335-
project,
336-
{ friendlyId: run.friendlyId },
337-
{ spanId: run.spanId }
338-
);
339-
return (
340-
<TableRow key={run.friendlyId}>
341-
<TableCell to={path}>{run.number}</TableCell>
342-
<TableCell to={path}>{run.taskIdentifier}</TableCell>
343-
<TableCell to={path}>
344-
{run.lockedToVersion?.version ?? "–"}
345-
</TableCell>
346-
<TableCell to={path}>
347-
<DateTime date={run.createdAt} />
348-
</TableCell>
349-
</TableRow>
350-
);
351-
})}
352-
</TableBody>
353-
</Table>
322+
<div className="max-h-[12.5rem] overflow-y-auto rounded border-b border-grid-bright">
323+
<Table className="w-full">
324+
<TableHeader>
325+
<TableRow>
326+
<TableHeaderCell>Run #</TableHeaderCell>
327+
<TableHeaderCell>Task</TableHeaderCell>
328+
<TableHeaderCell>Version</TableHeaderCell>
329+
<TableHeaderCell>Created at</TableHeaderCell>
330+
</TableRow>
331+
</TableHeader>
332+
<TableBody>
333+
{span.triggeredRuns.map((run) => {
334+
const path = v3RunSpanPath(
335+
organization,
336+
project,
337+
{ friendlyId: run.friendlyId },
338+
{ spanId: run.spanId }
339+
);
340+
return (
341+
<TableRow key={run.friendlyId}>
342+
<TableCell to={path} actionClassName="py-1.5">
343+
{run.number}
344+
</TableCell>
345+
<TableCell to={path} actionClassName="py-1.5">
346+
{run.taskIdentifier}
347+
</TableCell>
348+
<TableCell to={path} actionClassName="py-1.5">
349+
{run.lockedToVersion?.version ?? "–"}
350+
</TableCell>
351+
<TableCell to={path} actionClassName="py-1.5">
352+
<DateTime date={run.createdAt} />
353+
</TableCell>
354+
</TableRow>
355+
);
356+
})}
357+
</TableBody>
358+
</Table>
359+
</div>
354360
</div>
355361
</Property.Item>
356362
)}

0 commit comments

Comments
 (0)