improve unexpected exit error parsing

Author: nicktrn

packages/cli-v3/src/entryPoints/deploy-run-controller.ts

@@ -795,7 +795,7 @@ class ProdWorker {
                 id: execution.run.id,
                 ok: false,
                 retry: undefined,
-                error: TaskRunProcess.parseExecuteError(error),
+                error: TaskRunProcess.parseExecuteError(error, !this.runningInKubernetes),
               });
             } catch (error) {
               this.#failRun(message.lazyPayload.runId, error);

packages/cli-v3/src/executions/taskRunProcess.ts

@@ -23,7 +23,7 @@ import { logger } from "../utilities/logger.js";
 import {
   CancelledProcessError,
   CleanupProcessError,
-  getFriendlyErrorMessage,
+  internalErrorFromUnexpectedExit,
   GracefulExitTimeoutError,
   UnexpectedExitError,
 } from "@trigger.dev/core/v3/errors";
@@ -386,7 +386,7 @@ export class TaskRunProcess {
     return this._childPid;
   }
 
-  static parseExecuteError(error: unknown): TaskRunInternalError {
+  static parseExecuteError(error: unknown, dockerMode = false): TaskRunInternalError {
     if (error instanceof CancelledProcessError) {
       return {
         type: "INTERNAL_ERROR",
@@ -402,12 +402,7 @@ export class TaskRunProcess {
     }
 
     if (error instanceof UnexpectedExitError) {
-      return {
-        type: "INTERNAL_ERROR",
-        code: TaskRunErrorCodes.TASK_PROCESS_EXITED_WITH_NON_ZERO_CODE,
-        message: getFriendlyErrorMessage(error.code, error.signal, error.stderr),
-        stackTrace: error.stderr,
-      };
+      return internalErrorFromUnexpectedExit(error, dockerMode);
     }
 
     return {

packages/core/src/v3/errors.ts

@@ -400,32 +400,37 @@ export function exceptionEventEnhancer(
   return exception;
 }
 
-export function getFriendlyErrorMessage(
-  code: number,
-  signal: NodeJS.Signals | null,
-  stderr: string | undefined,
+export function internalErrorFromUnexpectedExit(
+  error: UnexpectedExitError,
   dockerMode = true
-) {
-  if (code === 137) {
+): TaskRunInternalError {
+  if (error.code === 137) {
     if (dockerMode) {
-      return message(
-        "Process ran out of memory! Try choosing a machine preset with more memory for this task."
-      );
+      return {
+        type: "INTERNAL_ERROR",
+        code: TaskRunErrorCodes.TASK_PROCESS_OOM_KILLED,
+      };
     } else {
-      // Note: containerState reason and message should be checked to clarify the error
-      return message(
-        "Process most likely ran out of memory, but we can't be certain. Try choosing a machine preset with more memory for this task."
-      );
+      // Note: containerState reason and message could be checked to clarify the error, maybe the task monitor should be allowed to override these
+      return {
+        type: "INTERNAL_ERROR",
+        code: TaskRunErrorCodes.TASK_PROCESS_MAYBE_OOM_KILLED,
+      };
     }
   }
 
-  if (stderr?.includes("OOMErrorHandler")) {
-    return message(
-      "Process ran out of memory! Try choosing a machine preset with more memory for this task."
-    );
+  if (error.stderr?.includes("OOMErrorHandler")) {
+    return {
+      type: "INTERNAL_ERROR",
+      code: TaskRunErrorCodes.TASK_PROCESS_OOM_KILLED,
+    };
   }
 
-  return message(`Process exited with code ${code}.`);
+  return {
+    type: "INTERNAL_ERROR",
+    code: TaskRunErrorCodes.TASK_PROCESS_EXITED_WITH_NON_ZERO_CODE,
+    message: `Process exited with code ${error.code} after signal ${error.signal}.`,
+  };
 }
 
 export function serializeIndexingError(error: unknown, stderr?: string): DeploymentErrorData {