Increase the tags limit to 5, do the limiting on the server

Author: matt-aitken

apps/webapp/app/models/taskRunTag.server.ts

@@ -1,6 +1,8 @@
 import { prisma } from "~/db.server";
 import { generateFriendlyId } from "~/v3/friendlyIdentifiers";
 
+export const MAX_TAGS_PER_RUN = 5;
+
 export async function createTag({ tag, projectId }: { tag: string; projectId: string }) {
   if (tag.trim().length === 0) return;
   return prisma.taskRunTag.upsert({

apps/webapp/app/routes/api.v1.runs.$runId.tags.ts

@@ -2,7 +2,7 @@ import { type ActionFunctionArgs, json } from "@remix-run/server-runtime";
 import { AddTagsRequestBody } from "@trigger.dev/core/v3";
 import { z } from "zod";
 import { prisma } from "~/db.server";
-import { createTag, getTagsForRunId } from "~/models/taskRunTag.server";
+import { createTag, getTagsForRunId, MAX_TAGS_PER_RUN } from "~/models/taskRunTag.server";
 import { authenticateApiRequest } from "~/services/apiAuth.server";
 import { generateFriendlyId } from "~/v3/friendlyIdentifiers";
 
@@ -51,12 +51,12 @@ export async function action({ request, params }: ActionFunctionArgs) {
       return !existingTags.map((t) => t.name).includes(tag);
     });
 
-    if (existingTags.length + newTags.length > 3) {
+    if (existingTags.length + newTags.length > MAX_TAGS_PER_RUN) {
       return json(
         {
-          error: `Runs can only have 3 tags, you're trying to set ${
+          error: `Runs can only have ${MAX_TAGS_PER_RUN} tags, you're trying to set ${
             existingTags.length + newTags.length
-          }.`,
+          }. These tags have not been set: ${newTags.map((t) => `'${t}'`).join(", ")}.`,
         },
         { status: 422 }
       );

apps/webapp/app/v3/services/triggerTask.server.ts

@@ -17,7 +17,7 @@ import { getEntitlement } from "~/services/platform.v3.server";
 import { BaseService, ServiceValidationError } from "./baseService.server";
 import { logger } from "~/services/logger.server";
 import { isFinalAttemptStatus, isFinalRunStatus } from "../taskStatus";
-import { createTag } from "~/models/taskRunTag.server";
+import { createTag, MAX_TAGS_PER_RUN } from "~/models/taskRunTag.server";
 
 export type TriggerTaskServiceOptions = {
   idempotencyKey?: string;
@@ -78,6 +78,16 @@ export class TriggerTaskService extends BaseService {
         }
       }
 
+      if (
+        body.options?.tags &&
+        typeof body.options.tags !== "string" &&
+        body.options.tags.length > MAX_TAGS_PER_RUN
+      ) {
+        throw new ServiceValidationError(
+          `Runs can only have ${MAX_TAGS_PER_RUN} tags, you're trying to set ${body.options.tags.length}.`
+        );
+      }
+
       const runFriendlyId = generateFriendlyId("run");
 
       const payloadPacket = await this.#handlePayloadPacket(

packages/core/src/v3/schemas/api.ts

@@ -57,10 +57,7 @@ export type CreateBackgroundWorkerResponse = z.infer<typeof CreateBackgroundWork
 
 //an array of 1, 2, or 3 strings
 const RunTag = z.string().max(64, "Tags must be less than 64 characters");
-export const RunTags = z.union([
-  RunTag,
-  RunTag.array().max(3, "You can only set a maximum of 3 tags on a run."),
-]);
+export const RunTags = z.union([RunTag, RunTag.array()]);
 
 export type RunTags = z.infer<typeof RunTags>;