Skip to content

Commit c87ff2c

Browse files
committed
Various fixes for no longer having the exportName
1 parent 233a22d commit c87ff2c

File tree

4 files changed

+13
-22
lines changed

4 files changed

+13
-22
lines changed

apps/webapp/app/components/runs/v3/TaskPath.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ export function TaskPath({ filePath, functionName, className }: TaskPathProps) {
1919
);
2020
}
2121

22-
type TaskFunctionNameProps = {
23-
functionName: string;
22+
type TaskFileNameProps = {
23+
fileName: string;
2424
variant?: InlineCodeVariant;
2525
className?: string;
2626
};
2727

28-
export function TaskFunctionName({ variant, functionName, className }: TaskFunctionNameProps) {
28+
export function TaskFileName({ variant, fileName, className }: TaskFileNameProps) {
2929
return (
3030
<InlineCode variant={variant} className={cn("text-text-dimmed", className)}>
31-
{`${functionName}()`}
31+
{`${fileName}`}
3232
</InlineCode>
3333
);
3434
}

apps/webapp/app/presenters/v3/SpanPresenter.server.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,6 @@ export class SpanPresenter extends BasePresenter {
269269
task: {
270270
id: run.taskIdentifier,
271271
filePath: run.lockedBy?.filePath,
272-
exportName: run.lockedBy?.exportName,
273272
},
274273
run: {
275274
id: run.friendlyId,

apps/webapp/app/presenters/v3/TaskListPresenter.server.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ import { BasePresenter } from "./basePresenter.server";
1515
import { TaskRunStatus } from "~/database-types";
1616
import { CURRENT_DEPLOYMENT_LABEL } from "@trigger.dev/core/v3/isomorphic";
1717

18-
export type Task = {
18+
export type TaskListItem = {
1919
slug: string;
20-
exportName: string;
2120
filePath: string;
2221
createdAt: Date;
2322
triggerSource: TaskTriggerSource;
@@ -60,7 +59,6 @@ export class TaskListPresenter extends BasePresenter {
6059
{
6160
id: string;
6261
slug: string;
63-
exportName: string;
6462
filePath: string;
6563
createdAt: Date;
6664
triggerSource: TaskTriggerSource;
@@ -81,7 +79,7 @@ export class TaskListPresenter extends BasePresenter {
8179
OR id IN (SELECT id FROM non_dev_workers)
8280
ORDER BY "runtimeEnvironmentId", "createdAt" DESC
8381
)
84-
SELECT tasks.id, slug, "filePath", "exportName", "triggerSource", tasks."runtimeEnvironmentId", tasks."createdAt"
82+
SELECT tasks.id, slug, "filePath", "triggerSource", tasks."runtimeEnvironmentId", tasks."createdAt"
8583
FROM workers
8684
JOIN ${sqlDatabaseSchema}."BackgroundWorkerTask" tasks ON tasks."workerId" = workers.id
8785
ORDER BY slug ASC;`;

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam._index/route.tsx

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ import {
5959
} from "~/components/primitives/Table";
6060
import { SimpleTooltip } from "~/components/primitives/Tooltip";
6161
import TooltipPortal from "~/components/primitives/TooltipPortal";
62-
import { TaskFunctionName } from "~/components/runs/v3/TaskPath";
62+
import { TaskFileName } from "~/components/runs/v3/TaskPath";
6363
import { TaskRunStatusCombo } from "~/components/runs/v3/TaskRunStatus";
6464
import {
6565
taskTriggerSourceDescription,
@@ -71,8 +71,8 @@ import { useOrganization } from "~/hooks/useOrganizations";
7171
import { useProject } from "~/hooks/useProject";
7272
import { useTextFilter } from "~/hooks/useTextFilter";
7373
import {
74-
type Task,
7574
type TaskActivity,
75+
type TaskListItem,
7676
TaskListPresenter,
7777
} from "~/presenters/v3/TaskListPresenter.server";
7878
import {
@@ -154,19 +154,13 @@ export default function Page() {
154154
const environment = useEnvironment();
155155
const { tasks, activity, runningStats, durations, usefulLinksPreference } =
156156
useTypedLoaderData<typeof loader>();
157-
const { filterText, setFilterText, filteredItems } = useTextFilter<Task>({
157+
const { filterText, setFilterText, filteredItems } = useTextFilter<TaskListItem>({
158158
items: tasks,
159159
filter: (task, text) => {
160160
if (task.slug.toLowerCase().includes(text.toLowerCase())) {
161161
return true;
162162
}
163163

164-
if (
165-
task.exportName.toLowerCase().includes(text.toLowerCase().replace("(", "").replace(")", ""))
166-
) {
167-
return true;
168-
}
169-
170164
if (task.filePath.toLowerCase().includes(text.toLowerCase())) {
171165
return true;
172166
}
@@ -213,7 +207,7 @@ export default function Page() {
213207
<Property.Table>
214208
{tasks.map((task) => (
215209
<Property.Item key={task.slug}>
216-
<Property.Label>{task.exportName}</Property.Label>
210+
<Property.Label>{task.filePath}</Property.Label>
217211
</Property.Item>
218212
))}
219213
</Property.Table>
@@ -258,7 +252,7 @@ export default function Page() {
258252
<TableHeader>
259253
<TableRow>
260254
<TableHeaderCell>Task ID</TableHeaderCell>
261-
<TableHeaderCell>Task</TableHeaderCell>
255+
<TableHeaderCell>File</TableHeaderCell>
262256
<TableHeaderCell>Running</TableHeaderCell>
263257
<TableHeaderCell>Queued</TableHeaderCell>
264258
<TableHeaderCell>Activity (7d)</TableHeaderCell>
@@ -289,8 +283,8 @@ export default function Page() {
289283
</div>
290284
</TableCell>
291285
<TableCell to={path}>
292-
<TaskFunctionName
293-
functionName={task.exportName}
286+
<TaskFileName
287+
fileName={task.filePath}
294288
variant="extra-extra-small"
295289
/>
296290
</TableCell>

0 commit comments

Comments
 (0)