Skip to content

Commit d4d3e3a

Browse files
committed
Couple of fixes from CodeRabbit
1 parent ebbc2d7 commit d4d3e3a

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

packages/core/src/v3/runMetadata/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class RunMetadataAPI implements RunMetadataManager {
9494
}
9595

9696
refresh(requestOptions?: ApiRequestOptions): Promise<void> {
97-
return this.#getManager().flush(requestOptions);
97+
return this.#getManager().refresh(requestOptions);
9898
}
9999

100100
get parent(): RunMetadataUpdater {

packages/core/src/v3/runMetadata/manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class StandardMetadataManager implements RunMetadataManager {
9393
return this.root;
9494
},
9595
update: (value) => {
96-
this.queuedParentOperations.add({ type: "update", value });
96+
this.queuedRootOperations.add({ type: "update", value });
9797
return this.root;
9898
},
9999
stream: (key, value, signal) => this.doStream(key, value, "root", this.root, signal),

packages/core/src/v3/runMetadata/noopManager.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,19 @@ export class NoopRunMetadataManager implements RunMetadataManager {
6565

6666
get root(): RunMetadataUpdater {
6767
return {
68-
append: () => this.parent,
69-
set: () => this.parent,
70-
del: () => this.parent,
71-
increment: () => this.parent,
72-
decrement: () => this.parent,
73-
remove: () => this.parent,
68+
append: () => this.root,
69+
set: () => this.root,
70+
del: () => this.root,
71+
increment: () => this.root,
72+
decrement: () => this.root,
73+
remove: () => this.root,
7474
stream: () =>
7575
Promise.resolve({
7676
[Symbol.asyncIterator]: () => ({
7777
next: () => Promise.resolve({ done: true, value: undefined }),
7878
}),
7979
}),
80-
update: () => this.parent,
80+
update: () => this.root,
8181
};
8282
}
8383
}

0 commit comments

Comments
 (0)