Skip to content

Commit ed5b5c4

Browse files
committed
Fix resolve only external dependencies versions
1 parent a6d6cb0 commit ed5b5c4

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1689,14 +1689,19 @@ export async function resolveRequiredDependencies(
16891689
config: ResolvedConfig
16901690
) {
16911691
return await tracer.startActiveSpan("resolveRequiredDependencies", async (span) => {
1692-
span.setAttribute("resolvablePackageNames", Object.keys(directDependenciesMeta));
1692+
const externalDirectDependenciesVersion = Object.fromEntries(
1693+
Object.entries(directDependenciesMeta)
1694+
.filter(([, { external }]) => external)
1695+
.map(([packageName, { version }]) => [packageName, version])
1696+
);
1697+
span.setAttribute("resolvablePackageNames", Object.keys(externalDirectDependenciesVersion));
16931698

1694-
const missingPackages = Object.entries(directDependenciesMeta)
1695-
.filter(([, pkgMeta]) => !pkgMeta.version)
1699+
const missingPackages = Object.entries(externalDirectDependenciesVersion)
1700+
.filter(([, version]) => !version)
16961701
.map(([name]) => name);
16971702

16981703
span.setAttributes({
1699-
...flattenAttributes(directDependenciesMeta, "resolvedPackageVersions"),
1704+
...flattenAttributes(externalDirectDependenciesVersion, "resolvedPackageVersions"),
17001705
});
17011706
span.setAttribute("missingPackages", missingPackages);
17021707

@@ -1712,7 +1717,7 @@ export async function resolveRequiredDependencies(
17121717
}
17131718
}
17141719

1715-
for (const [packageName, { version }] of Object.entries(directDependenciesMeta)) {
1720+
for (const [packageName, version] of Object.entries(externalDirectDependenciesVersion)) {
17161721
dependencies[packageName] = version;
17171722
}
17181723

@@ -1730,7 +1735,7 @@ export async function resolveRequiredDependencies(
17301735
dependencies[packageParts.name] = packageParts.version;
17311736
continue;
17321737
} else {
1733-
const externalDependencyVersion = directDependenciesMeta[packageParts.name]?.version;
1738+
const externalDependencyVersion = externalDirectDependenciesVersion[packageParts.name];
17341739

17351740
if (externalDependencyVersion) {
17361741
dependencies[packageParts.name] = externalDependencyVersion;

0 commit comments

Comments
 (0)